Page MenuHomePhabricator

[versioned maps] Interactive map fails to render after save
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Blocks versioned maps deployment.

List of steps to reproduce (step by step, including full links if applicable):

  • Given a wiki with FlaggedRevs configured to stabilize all pages, and versioned maps enabled,
  • Use VisualEditor to edit a mapframe and change marker properties.
  • Save page.

What happens?:
On the first pageview, two different backend mapdata requests are made. Both have the same group ID but differing revision IDs:

172.25.0.6 - - [05/May/2022:08:21:59 +0200] "GET /w/api.php?format=json&formatversion=2&action=query&revids=6960&prop=mapdata&mpdlimit=max&mpdgroups=_57d5efc11105bac13fca4da96af324a13f8824a9 HTTP/1.1" 200 391 "-" "kartotherian (yurik @ wikimedia)"
127.0.0.1 - - [05/May/2022:08:21:59 +0200] "GET /w/api.php?action=query&format=json&formatversion=2&revids=6959&prop=mapdata&mpdlimit=max&mpdgroups=_57d5efc11105bac13fca4da96af324a13f8824a9 HTTP/1.1" 200 215 "http://wiki..." "Firefox..."

What should have happened instead?:
One or the other of,

On the next pageview, everything works fine.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

awight triaged this task as High priority.
awight created this task.
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2022-04-27 board.

Change 789549 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Kartographer@master] Refresh MediaWiki globals when loading mapdata

https://gerrit.wikimedia.org/r/789549

awight removed awight as the assignee of this task.May 5 2022, 7:15 AM
awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2022-04-27 board.

Change 789554 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] [POC] Delay initialization of DataManager

https://gerrit.wikimedia.org/r/789554

Change 789554 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] [POC] Delay initialization of DataManager

Reason:

https://gerrit.wikimedia.org/r/789554

thiemowmde updated the task description. (Show Details)
thiemowmde set the point value for this task to 3.

Change 789549 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Refresh MediaWiki globals when loading mapdata

https://gerrit.wikimedia.org/r/789549

Change 790329 had a related patch set uploaded (by WMDE-Fisch; author: Awight):

[mediawiki/extensions/Kartographer@wmf/1.39.0-wmf.10] Refresh MediaWiki globals when loading mapdata

https://gerrit.wikimedia.org/r/790329

Change 790329 merged by Clare Ming:

[mediawiki/extensions/Kartographer@wmf/1.39.0-wmf.10] Refresh MediaWiki globals when loading mapdata

https://gerrit.wikimedia.org/r/790329

Mentioned in SAL (#wikimedia-operations) [2022-05-09T20:32:25Z] <cjming@deploy1002> Synchronized php-1.39.0-wmf.10/extensions/Kartographer/modules/box: Backport: [[gerrit:790329|Refresh MediaWiki globals when loading mapdata (T307650)]] (duration: 00m 52s)

thiemowmde claimed this task.