Use manageForeignResources.php to manage OpenSeadragon dependency
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Samwilson
	May 5 2022, 12:59 PM

Description

In this patch the package.json dependency on openseadragon was removed. We need to switch to the proper way of managing foreign resources, as described in https://www.mediawiki.org/wiki/Manual:ManageForeignResources.php

Details

	Subject	Repo	Branch	Lines +/-
	Switch to foreign-resources for loading OpenSeadragon	mediawiki/extensions/ProofreadPage	master	+1 K -1 K

Customize query in gerrit

Related Objects

Mentioned Here: T304292: Update Openseadragon to 3.0.0 from git hash

Event Timeline

Samwilson created this task.May 5 2022, 12:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2022, 12:59 PM

Jdforrester-WMF subscribed.May 5 2022, 3:38 PM

Soda subscribed.May 5 2022, 5:52 PM

Is there any current extensions that use the ManageForeignResources.php script ? I'm working on and off on T304292 and might take a look at this alongside it.

That'd be great!

It looks like WikiLambda, GrowthExperiments, and DiscussionTools do.

Change 806367 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/ProofreadPage@master] Switch to foreign-resources for loading OpenSeadragon

https://gerrit.wikimedia.org/r/806367

gerritbot added a project: Patch-For-Review.Jun 17 2022, 7:57 AM

Samwilson claimed this task.Jun 22 2022, 7:24 AM

Change 806367 merged by jenkins-bot: