Page MenuHomePhabricator
Create Task
Maniphest T307688

Validate that the images used in a story actually exist
Closed, ResolvedPublic
Actions

Description

When creating a story from the edit API or the no-js form, it is possible to provide file names that don't exist and that creates a broken story.

We should validate that the files exist in a configure repo and fail validation if they don't.

Details

SubjectRepoBranchLines +/-
Test: invalid story: file not foundmediawiki/extensions/Wikistoriesmaster+14 -0
Validate that files used in story existmediawiki/extensions/Wikistoriesmaster+52 -11
Customize query in gerrit

Related Objects

Event Timeline

SBisson created this task.May 5 2022, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2022, 1:43 PM
SBisson moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.May 9 2022, 12:51 PM
SBisson claimed this task.May 9 2022, 1:56 PM
SBisson triaged this task as Medium priority.
SBisson moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
gerritbot added a comment.May 9 2022, 3:43 PM

Change 790394 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Validate that files used in story exist

https://gerrit.wikimedia.org/r/790394

gerritbot added a project: Patch-For-Review.May 9 2022, 3:43 PM
SBisson moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.May 9 2022, 3:44 PM
gerritbot added a comment.May 10 2022, 8:05 AM

Change 790394 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Validate that files used in story exist

https://gerrit.wikimedia.org/r/790394

SBisson mentioned this in rEWST25b0b58f2ddb: Validate that files used in story exist.May 10 2022, 8:06 AM
Maintenance_bot removed a project: Patch-For-Review.May 10 2022, 8:31 AM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 10 2022, 9:01 AM
gerritbot added a comment.May 10 2022, 2:51 PM

Change 790704 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Test: invalid story: file not found

https://gerrit.wikimedia.org/r/790704

gerritbot added a project: Patch-For-Review.May 10 2022, 2:51 PM
gerritbot added a comment.May 10 2022, 5:31 PM

Change 790704 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Test: invalid story: file not found

https://gerrit.wikimedia.org/r/790704

SBisson mentioned this in rEWST5ce2ebe711c5: Test: invalid story: file not found.May 10 2022, 5:31 PM
hueitan moved this task from Code Review to QA on the Inuka-Team (Kanban) board.May 11 2022, 9:06 AM
• EUdoh-WMF subscribed.Jun 8 2022, 9:23 PM

Testing:

Works as expected

image.png (914×1 px, 307 KB)

• EUdoh-WMF moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Jun 8 2022, 9:23 PM
SGautam_WMF closed this task as Resolved.Jun 13 2022, 3:48 AM
SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL