Page MenuHomePhabricator

Cite parser test failures with Parsoid
Open, MediumPublic


There are a few tests that are failing with Parsoid. Since we are going to migrate Parsoid's Cite implementation into the Cite extension repository in the near future, this task only collects failures when Parsoid is run in integrated mode (the only supported testing mode for all extensions).

  1. T242437 - Blank ref name in #tag regression
  2. T242437 - Nested references edge case, outer tag function with LDR
  3. T242437 - Nested references edge case, outer tag function, inner LDR
  4. Multiple definition (inside {{#tag:references}})
  5. Valid parameters become invalid when a third is present

While not strictly a failure, in 'T48140 - Make sure rollback/redo does not consume number' and 'Numbers in the default group need to start with 1, independent from other groups', the legacy Cite implementation skips over a count value whereas Parsoid doesn't which causes the cite's href links to be different.

Event Timeline

ssastry triaged this task as High priority.May 5 2022, 7:39 PM
ssastry lowered the priority of this task from High to Medium.May 5 2022, 9:25 PM

Looks like all the cases of {{#tag: .. }} is a case of having multiple data-mw sources and the mw:Transclusion data-mw taking precedence and throwing away other info. So, this is basically another instance of T214241: data-mw info is clobbered by template annotations.

So, where the references tag is templated and there are errors for refs defined in that references tag, we will suppress display of those errors. I am not sure how critical of an issue this is for read views.

So, the only test that needs investigation is the 5th one in the description. And, that is likely some missing validation checks and should be easily fixable.

Change 837758 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/Cite@master] WIP: Enable integrated testing with Parsoid

Change 837758 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Enable integrated testing with Parsoid

MSantos moved this task from Backlog to To Verify on the Content-Transform-Team-WIP board.
MSantos added a subscriber: MSantos.

This seems to be solved and needs verification, please move it back to backlog if that's not the case.