Description
We now have one gradient left over from the previous design, which does not fit into the current concept and does not correspond to the style guide. We should update this to a solid gray line (#C8CCD1).
| current | updated |
|---|---|
| Iniquity | |
| May 6 2022, 9:56 AM |
| F35489527: Screen Shot 2022-08-25 at 10.51.48 AM.png | |
| Aug 25 2022, 8:51 AM |
| F35488727: Screen Shot 2022-08-24 at 7.40.22 PM.png | |
| Aug 25 2022, 2:41 AM |
| F35378468: Screen Shot 2022-08-01 at 4.26.24 PM.png | |
| Aug 1 2022, 8:32 PM |
| F35378466: Screen Shot 2022-08-01 at 4.26.00 PM.png | |
| Aug 1 2022, 8:32 PM |
| F35378463: Screen Shot 2022-08-01 at 4.25.12 PM.png | |
| Aug 1 2022, 8:32 PM |
| F35343271: изображение.png | |
| Jul 26 2022, 8:22 PM |
| F35342960: image.png | |
| Jul 26 2022, 7:49 PM |
| F35342958: image.png | |
| Jul 26 2022, 7:49 PM |
We now have one gradient left over from the previous design, which does not fit into the current concept and does not correspond to the style guide. We should update this to a solid gray line (#C8CCD1).
| current | updated |
|---|---|
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T309972 [Goal] prepare desktop improvements project for further deployment | |||
| Resolved | ovasileva | T301780 [Epic] Visual design & layout refinements | |||
| Resolved | Edtadros | T307771 Remove custom gradients from new vector sidebar |
Right, the center-to-sides gradient (left over from the times when the menu looked like this) doesn't make sense in old Vector as well.
This was partially done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/803355
There are no plans to touch old Vector.
@alexhollender_WMF do we want to remove the subtle gradient in the sidebar, or is that mute given the future reorganization of the sidebar?
Current (Interaction underline is what we are talking about);
Maybe?:
@alexhollender_WMF hi! :) And what are we going to do with the gradient in the left menu?
If the gradient is kept, a left-to-right gradient would make more sense from the design point of view. A center-to-sides gradient, as I said, is a leftover from the times when the menu looked like this.
@alexhollender_WMF - do we want to go ahead with this task or create a new one based on the feedback from the current prototype testing round?
we can use this task but I think we should wait a bit longer on this and do it together with some other visual changes we're going to be making to the menus
@ovasileva @Jdlrobson I've updated this task and it's ready to be included in the Visual refinements part 2 work
Maybe instead of having separators, we should remove them completely, and make the section headings bolder (font-weight: 600)?
I think that is a reasonable proposal. My assumption is: for larger menus (such as this one) the border lines, combined with spacing and the different font-style of the section headings, help break the menu into sections, and make it easier for people to scan. I wonder if removing the border lines makes the menu groupings harder to scan? I am not aware of any research we have done regarding this. I did take a quick look around and have found some other menus that use similar dividers/borders, which may serve as reference points:
| YouTube | GitHub | New York Times |
|---|---|---|
Looking at our design style guide we have a "Menu" component (link), though it is more of a Select menu. I think the designs systems team is planning to further develop this component, so perhaps this question of sections & divider lines is something they will take into consideration. cc @Sarai-WMDE
Thanks for the heads-up on this one! In Codex, we defined some early specification for a potential divider mixin/component. The light variant is a solid 1px line/border that presents the color suggested in this ticket: #C8CCD1. Looks like we're aligned!
So:
Change 822658 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Remove gradient from modern Vector, align SidebarAction with portlet styles and classes
Change 822658 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove gradient from modern Vector, align SidebarAction with portlet styles and classes
Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Replace gradient line separator in collapsible sidebar with a solid gray line.