Page MenuHomePhabricator
Create Task
Maniphest T307773

Recording: "Click on $1 below" i18n variable not replaced on Special:RecordWizard step 4
Closed, ResolvedPublic6 Estimated Story PointsBUG REPORT
Actions

Description

Twin with T281038
List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • The help message states Click on $1 below, then read the word aloud

image.png (617×969 px, 35 KB)

What should have happened instead?:

  • The $1 variable should either be replaced with a translatable phrase, or properly replaced. E.g:

image.png (612×954 px, 35 KB)

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Avenues:
In the Record Wizard, Step 4: Studio, this sentence is displayed ("Click on $1 below, then read the word aloud").
Likely a broken variable transmission or something.

This icon changes if we switch to handsign video recording. Thereby:

  • if language's media audio, then mic-blue.svg
  • if language's media video, then hands-blue.svg

See ext.studio.css#L259-L268

See also :

Related Objects

Event Timeline

TheresNoTime created this task.May 6 2022, 11:14 AM
Yug renamed this task from i18n variable not replaced on Special:RecordWizard step 4 to "Click on $1 below" i18n variable not replaced on Special:RecordWizard step 4.Jul 6 2022, 10:48 AM
Yug triaged this task as High priority.
Yug raised the priority of this task from High to Unbreak Now!.Jul 6 2022, 10:50 PM
Yug mentioned this in T281038: Recording: Click on $1 below, then read the word aloud.
Yug updated the task description. (Show Details)
Yug renamed this task from "Click on $1 below" i18n variable not replaced on Special:RecordWizard step 4 to Recording: "Click on $1 below" i18n variable not replaced on Special:RecordWizard step 4.Jul 7 2022, 3:07 PM
Yug merged a task: T281038: Recording: Click on $1 below, then read the word aloud.Jul 7 2022, 8:09 PM
Yug added subscribers: Pamputt, Poslovitch, Yug and 4 others.
Yug updated the task description. (Show Details)Jul 7 2022, 8:12 PM
Yug added a comment.EditedJul 7 2022, 8:14 PM

The en.json messages files in English has this precise two messages.

	"mwe-recwiz-studio-info-audio": "Click on $1 below, then read the word aloud.",
	"mwe-recwiz-studio-info-video": "Click on $1 below, then say the word in sign language",

They are then used in /specials/templates/studio.mustache

		<div id="mwe-rws-info-audio" class="mwe-rw-info">
			{{&_ "mwe-recwiz-studio-info-audio" "<i></i>"}}
		</div>
		<div id="mwe-rws-info-video" class="mwe-rw-info">
			{{&_ "mwe-recwiz-studio-info-video" "<i></i>"}}
		</div>

This is the only case of value replacement within .mustache file. Other occurrence are done via vue.js files.

The system is supposed to do the replacement of $1 by <i></i> here must be broken somehow.

To test the solution :
Record wizard, got to step 4 : Studio. "$1" is visible.
Open the inspector, open the console tab, paste and run :

$("#mwe-rws-info-audio").html($("#mwe-rws-info-audio").text().replace("$1","<i></i>"));
$("#mwe-rws-info-video").html($("#mwe-rws-info-audio").text().replace("$1","<i></i>"));

It will then display properly.

tstarling lowered the priority of this task from Unbreak Now! to High.Jul 15 2022, 6:15 AM
tstarling added a subscriber: tstarling.

I don't think this is "unbreak now". See https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels for information about setting task priority.

Yug claimed this task.Jul 19 2022, 5:25 PM
Yug edited projects, added Lingua Libre (Hackathon 2022); removed Lingua Libre.Jul 21 2022, 5:42 PM
Yug set the point value for this task to 6.Jul 21 2022, 6:22 PM
Poslovitch added a comment.Aug 22 2022, 7:39 PM

Was reported again on GIthub : https://github.com/lingua-libre/RecordWizard/issues/17

0x010C claimed this task.Apr 10 2023, 1:03 PM
Yug added a comment.EditedApr 10 2023, 4:12 PM

@0x010C , please be aware of the recent and dirty JS fix in MediaWiki:Common.js.

0x010C added a comment.Apr 14 2023, 3:25 PM

Done in commit 4addc776.
The mustach helper function used for I18n was not supporting message parameters.

0x010C closed this task as Resolved.Apr 14 2023, 3:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL