TypeError: Cannot read property 'indexOf' of undefined
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	cjming
	May 6 2022, 4:11 PM

Description

Error

mwversion: 1.39.0-wmf.10
reqId: e85b9ae2-60fe-4d89-bcf7-f3cb8b0930d9
Find reqId in Logstash

normalized_message

TypeError: Cannot read property 'indexOf' of undefined

exception.trace

at getMissingFrequentLanguages  <anonymous>:17:793
at <anonymous>:18:755
at Object.fire  <anonymous>:374:636
at onOpen  <anonymous>:220:407
at https://en.m.wikipedia.org/w/load.php?lang=en&modules=mobile.languages.structured&skin=minerva&version=1x4fg:2:460

Impact

239 in last 12 hours - https://logstash.wikimedia.org/goto/c46db792991ec36b8ae3ceba8a21a470

Notes

Affecting mobile domains - mostly en.m.wikipedia.org plus a few others

Details

	Subject	Repo	Branch	Lines +/-
	mffrequentlanguages entryopoint: Handle the case of undefined deviceLanguage	mediawiki/extensions/ContentTranslation	master	+14 -14

Customize query in gerrit

Event Timeline

cjming created this task.May 6 2022, 4:11 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 6 2022, 4:11 PM

cjming added a project: Web-Team-Backlog.May 6 2022, 4:48 PM

cjming moved this task from Incoming to Needs Prioritization (Tech) on the Web-Team-Backlog board.

cjming edited projects, added Web-Team-Backlog (Needs Prioritization (Tech)); removed Web-Team-Backlog.

Hi language team just wanted to check in that you are aware of and handling this issue?

Per https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/1acba64b5f45125f60f48e4e0437089313f49237/src/mobile.startup/languageOverlay/getDeviceLanguage.js#8 deviceLanguage can be undefined but getMissingFrequentLanguages only expects a string.

@ngkountas Would this be a trivial fix?

Yes, it is quite a simple fix. I have it ready and will publish it today.

Umherirrender added a project: JavaScript.May 15 2022, 6:03 PM

Change 791827 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] mffrequentlanguages entryopoint: Handle the case of undefined deviceLanguage

https://gerrit.wikimedia.org/r/791827

gerritbot added a project: Patch-For-Review.May 16 2022, 6:47 AM

• santhosh triaged this task as Medium priority.May 16 2022, 6:47 AM

• santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.

Change 791827 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] mffrequentlanguages entryopoint: Handle the case of undefined deviceLanguage

https://gerrit.wikimedia.org/r/791827

Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 10:30 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 17 2022, 7:00 AM

Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.May 17 2022, 11:02 AM

thcipriani moved this task from Untriaged to May 2022 on the Wikimedia-production-error board.May 19 2022, 3:50 PM

ngkountas moved this task from Recheck after deployment to Needs QA on the Language-Team (Language-2022-April-June) board.May 30 2022, 12:26 PM

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-April-June) board.Jun 8 2022, 3:28 AM

Jdlrobson awarded a token.Jun 8 2022, 2:44 PM

	F35217972: Screenshot 2022-06-08 at 10.46.26.png
	Jun 8 2022, 8:47 AM

TypeError: Cannot read property 'indexOf' of undefinedClosed, ResolvedPublicPRODUCTION ERRORActions