Page MenuHomePhabricator

Manual reload shortcut causes the RTP pane to reopen
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

As discovered in T307793, if I press the RTP manual reload shortcut with the RTP pane closed, it reopens.

Steps to reproduce problem
  1. Start an edit session
  2. Open the RTP pane
  3. Close the pane
  4. Press the RTP manual reload shortcut ( alt+) or cmd+opt+) )

Expected behavior: Nothing happens โ€” the RTP pane is closed therefore there is "nothing" to refresh
Observed behavior: The RTP pane reopens

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptMay 6 2022, 4:21 PM

Change 789855 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/WikiEditor@master] Realtime preview: Suppress reopening pane

https://gerrit.wikimedia.org/r/789855

Yes, I must admit the shortcut feature was a bit ill-defined and added without much design oversight. Sorry everyone! :-)

Yes, I must admit the shortcut feature was a bit ill-defined and added without much design oversight. Sorry everyone! :-)

Macro scremcat:  Its a feature!

Change 789855 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: Suppress reopening pane

https://gerrit.wikimedia.org/r/789855

Feature is not reloading when refresh via opt + command key

Feature is not reloading when refresh via opt + command key

Just to confirm, that's when you're pressing โŒ˜+โŒฅ+) ( command + option + ) ) ?