Manual reload shortcut causes the RTP pane to reopen
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	TheresNoTime
	May 6 2022, 4:21 PM

Description

What is the problem?

As discovered in T307793, if I press the RTP manual reload shortcut with the RTP pane closed, it reopens.

Steps to reproduce problem

Start an edit session
Open the RTP pane
Close the pane
Press the RTP manual reload shortcut ( alt+) or cmd+opt+) )

Expected behavior: Nothing happens — the RTP pane is closed therefore there is "nothing" to refresh
Observed behavior: The RTP pane reopens

Details

	Subject	Repo	Branch	Lines +/-
	Realtime preview: Suppress reopening pane	mediawiki/extensions/WikiEditor	master	+6 -7

Customize query in gerrit

Related Objects

Mentioned In: T307793: Preview button remains blue after opening with shortcut
T307473: Shortcut does not open Preview first time
T306880: In manual-mode, shortcut key does not open preview if it has been closed
Mentioned Here: T306880: In manual-mode, shortcut key does not open preview if it has been closed
T307473: Shortcut does not open Preview first time
T307793: Preview button remains blue after opening with shortcut

Event Timeline

TheresNoTime created this task.May 6 2022, 4:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2022, 4:21 PM

Change 789855 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/WikiEditor@master] Realtime preview: Suppress reopening pane

https://gerrit.wikimedia.org/r/789855

gerritbot added a project: Patch-For-Review.May 6 2022, 4:23 PM

TheresNoTime claimed this task.May 6 2022, 4:24 PM

Fairly sure this errant behaviour has contributed to the following (un)expected behaviour bugs:

TheresNoTime updated the task description. (Show Details)May 6 2022, 4:46 PM

Yes, I must admit the shortcut feature was a bit ill-defined and added without much design oversight. Sorry everyone! :-)

In T307805#7910995, @Samwilson wrote:

Yes, I must admit the shortcut feature was a bit ill-defined and added without much design oversight. Sorry everyone! :-)

Macro scremcat: Its a feature!

Samwilson edited projects, added Community-Tech (CommTech-Sprint-24); removed Community-Tech.May 9 2022, 1:38 AM

Change 789855 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Realtime preview: Suppress reopening pane

https://gerrit.wikimedia.org/r/789855

Samwilson moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-24) board.May 9 2022, 1:50 AM

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 9 2022, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 9 2022, 2:30 AM

In T307805#7910262, @TheresNoTime wrote:

Fairly sure this errant behaviour has contributed to the following (un)expected behaviour bugs:

T307473: Shortcut does not open Preview first time

T307793: Preview button remains blue after opening with shortcut

T306880: In manual-mode, shortcut key does not open preview if it has been closed

Can these be closed as invalid? 🐛🔨

Feature is not reloading when refresh via opt + command key

• imaigwilo moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-24) board.May 11 2022, 8:37 PM

dom_walden mentioned this in T306880: In manual-mode, shortcut key does not open preview if it has been closed.May 12 2022, 9:08 AM

In T307805#7922438, @imaigwilo wrote:

Feature is not reloading when refresh via opt + command key

Just to confirm, that's when you're pressing ⌘+⌥+) ( command + option + ) ) ?

• NRodriguez closed this task as Resolved.May 19 2022, 2:51 PM

TheresNoTime mentioned this in T307473: Shortcut does not open Preview first time.May 19 2022, 6:22 PM

TheresNoTime mentioned this in T307793: Preview button remains blue after opening with shortcut.

• JMcLeod_WMF moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-24) board.May 24 2022, 6:24 PM

Manual reload shortcut causes the RTP pane to reopenClosed, ResolvedPublicBUG REPORTActions