Page MenuHomePhabricator
Create Task
Maniphest T307807

"New comments" highlighted while drafting should be dismissible by clicking
Closed, ResolvedPublic
Actions

Description

When you click the popup to "show new comments" while drafting, those comments are highlighted in blue. For consistency, those highlights should be dismissed when you click (as happens with notification highlights).

Details

SubjectRepoBranchLines +/-
Dismiss "new comment" highlights when clickingmediawiki/extensions/DiscussionToolsmaster+5 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.May 6 2022, 4:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 6 2022, 4:43 PM
gerritbot added a comment.May 6 2022, 4:44 PM

Change 789856 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Dismiss "new comment" highlights when clicking

https://gerrit.wikimedia.org/r/789856

gerritbot added a project: Patch-For-Review.May 6 2022, 4:44 PM
Esanders claimed this task.May 6 2022, 4:44 PM
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
ppelberg mentioned this in T300560: Design persistent notification for when new comments are posted while drafting a reply.May 6 2022, 4:46 PM
Esanders added a comment.May 6 2022, 4:49 PM

Open a reply in https://patchdemo.wmflabs.org/wikis/85e257da81/w/index.php?title=Talk:DiscussionTools&oldid=23#Badminton_module and wait 10s for notification.

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.May 9 2022, 5:21 PM
DLynch added a project: Editing QA.
gerritbot added a comment.May 9 2022, 5:33 PM

Change 789856 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Dismiss "new comment" highlights when clicking

https://gerrit.wikimedia.org/r/789856

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 9 2022, 6:01 PM
Maintenance_bot removed a project: Patch-For-Review.May 9 2022, 6:30 PM
EAkinloose subscribed.May 16 2022, 7:19 PM
In T307807#7910310, @Esanders wrote:

Open a reply in https://patchdemo.wmflabs.org/wikis/85e257da81/w/index.php?title=Talk:DiscussionTools&oldid=23#Badminton_module and wait 10s for notification.

Highlight is dismissed as expected. See https://photos.app.goo.gl/hg44qDZns5RB665m8.

EAkinloose closed this task as Resolved.May 16 2022, 7:20 PM
EAkinloose reopened this task as Open.
EAkinloose edited projects, added Verified; removed Editing QA.
EAkinloose added a comment.May 16 2022, 7:22 PM

@ppelberg , do your thing. I meant to Change Project Tags.

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.May 16 2022, 7:23 PM
• iamjessklein added a comment.May 16 2022, 8:23 PM

Nice work @Esanders

ppelberg closed this task as Resolved.May 16 2022, 11:34 PM
In T307807#7932284, @EAkinloose wrote:

@ppelberg , do your thing. I meant to Change Project Tags.

🙂

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits