Page MenuHomePhabricator
Create Task
Maniphest T307848

Minerva desktop does not display amboxes
Open, Needs TriagePublic
Actions

Description

If you pick a page on desktop (en.wikipedia.org) amboxes are totally missing. Minerva on mobile (en.m.wikipedia.org) is fine and displays the 'custom' styling that is implemented (I think) by MF.

The file applying .ambox { display: none } appears to be /resources/skins.minerva.base.styles/content/templates/ambox.less

For a page of interest, https://en.wikipedia.org/wiki/Alternate_history displays amboxes in #History of literature and #Cross-time stories, https://en.m.wikipedia.org/wiki/Alternate_history displays the expected MF styling, but neither is present in https://en.wikipedia.org/wiki/Alternate_history?useskin=minerva .

Related Objects

Event Timeline

Izno created this task.May 7 2022, 8:59 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 7 2022, 8:59 PM
AlexisJazz edited projects, added MinervaNeue (Desktop); removed MinervaNeue.May 7 2022, 9:56 PM
Aklapper added a comment.May 8 2022, 2:21 AM

This sounds like T68747#702268 (and to some extent T143535 and T282984#7098855) to me.

Izno added a comment.May 8 2022, 2:26 AM
In T307848#7911820, @Aklapper wrote:

This sounds like T68747#702268 (and to some extent T143535 and T282984#7098855) to me.

It's not any of those.

AlexisJazz subscribed.May 8 2022, 8:44 AM
AlexisJazz mentioned this in T307851: Switch skin per device.May 8 2022, 9:25 AM
Jdlrobson added a project: patch-welcome.May 9 2022, 6:33 PM
Jdlrobson subscribed.

The Minerva overlays create a modal window so they only work with MobileFrontend installed. I think it would be fine to conditionally load this code on desktop too, as some third parties use Minerva without MobileFrontend.

Noting that on desktop modals take up the full screen and look terrible (see T146329 which was declined due to a lack of bandwidth). I'm hoping the work on Codex will provide a better path to building overlays inside the Minerva desktop experience but last time we checked Minerva desktop usage was very very low.

Screen Shot 2022-05-09 at 11.30.55 AM.png (1×2 px, 197 KB)

Stang subscribed.May 9 2022, 6:43 PM
AlexisJazz added a comment.May 9 2022, 10:58 PM
In T307848#7915177, @Jdlrobson wrote:

The Minerva overlays create a modal window so they only work with MobileFrontend installed. I think it would be fine to conditionally load this code on desktop too, as some third parties use Minerva without MobileFrontend.

Noting that on desktop modals take up the full screen and look terrible (see T146329 which was declined due to a lack of bandwidth). I'm hoping the work on Codex will provide a better path to building overlays inside the Minerva desktop experience but last time we checked Minerva desktop usage was very very low.

Screen Shot 2022-05-09 at 11.30.55 AM.png (1×2 px, 197 KB)

If T307851 was a reality and T306737 would be fixed I'm sure Minerva "desktop" usage (as in: people using Minerva on the desktop domain on their mobile devices) would be many times what it is now as it could become a decent mobile editing experience.

Asartea mentioned this in T310522: On Minerva desktop clicking the notification icon has no effect.Jun 13 2022, 4:31 PM
Izno mentioned this in T316986: Consider simplifying page issues styling on mobile.Sep 12 2022, 10:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits