Page MenuHomePhabricator

No CentralNotice on Minerva when setting no device category when notice not set for unknown devices
Closed, InvalidPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Nothing

What should have happened instead?:
Something

Event Timeline

image.png (160×722 px, 26 KB)

This seems to be the banner configuration

Tacsipacsi subscribed.

And it definitely works if configured that way.

Screenshot_2022-05-08-14-17-03.png (842×540 px, 153 KB)

@AlexisJazz, @Tacsipacsi thanks so much for looking at this!

Quick explanation:

When testing CentralNotice banners on the mobile skin using a desktop device, you may need to tell CentralNotice which device category to pretend you're on.

If you don't, the device will be categorized as "Unknown", and if a banner doesn't target "Unknown" devices, it won't show.

Here are some URLs that do work on the beta cluster on a desktop device:

CentralNotice uses really simple device detection logic: if you're not on the Minerva skin, you're a desktop device, and if not, you're one of the other devices.

Thanks again!! :)

Aklapper renamed this task from No CentralNotice on Minerva to No CentralNotice on Minerva when setting no device category when notice not set for unknown devices.May 9 2022, 7:24 AM

@AlexisJazz, @Tacsipacsi thanks so much for looking at this!

Quick explanation:

When testing CentralNotice banners on the mobile skin using a desktop device, you may need to tell CentralNotice which device category to pretend you're on.

If you don't, the device will be categorized as "Unknown", and if a banner doesn't target "Unknown" devices, it won't show.

Here are some URLs that do work on the beta cluster on a desktop device:

CentralNotice uses really simple device detection logic: if you're not on the Minerva skin, you're a desktop device, and if not, you're one of the other devices.

Thanks again!! :)

Just to confirm, I changed the banner settings to include "Unknown" and they do now appear on https://en.wikipedia.beta.wmflabs.org/wiki/Bert?useskin=minerva and https://en.m.wikipedia.beta.wmflabs.org/wiki/Bert

Thanks. I see @Tacsipacsi closed the task as invalid, strictly speaking this would be correct, but it seems like a shortcoming that CentralNotice considers desktops to be "unknown". When I'm thinking "unknown", I'm thinking E-readers, smartwatches, refrigerators, cars, oddball Chinese phablets running some Android knockoff, HarmonyOS, QNX, Amazon Silk. Stuff where the end result may not be fully predictable.

Also @AndyRussG that assumption is wrong. Timeless and Monobook are also used by mobile users.

This task, as a bug report, is invalid: first, banners appear on mobile web when configured so; second, for me the checkboxes are clear. Yes, using the mobile site from a desktop computer counts as unknown, since, as explained on the screenshot, unknown includes all devices using the mobile web that are not iPads, iPhones or Android devices. Desktop/laptop computers are neither of them. (You can technically run Windows or Linux on Android devices after rooting it—as far as I know—, but don’t be surprised if things don’t work how they should in this silly setting…) Feel free to create a new feature request to create a new category for desktops using the mobile version, but I don’t think it’s very important, as using the mobile version on desktop is quite an edge case. (Using the desktop version on mobile is fairly common, but not the other way round.)