Page MenuHomePhabricator

Dialog allows to insert invalid urls
Open, MediumPublic

Description

Steps to reproduce:

  1. Open a page for editing, chose the insert link dialog.
  2. Enter "a a" as url
  3. Chose "To an external web page" (If you ask why someone should do this, I can only say that I don't know, but that I've seen too many of these links to ignore them)
  4. Click "Insert Link"

Result: [http://a%20a a a] is inserted.
Expected result: The insert link button should be grayed out when the link to be inserted is definitely invalid.


Version: unspecified
Severity: normal

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:32 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz28789.
bzimport added a subscriber: Unknown Object (MLST).

Change 141367 had a related patch set uploaded by TheDJ:
Link dialog: do basic URI validation

https://gerrit.wikimedia.org/r/141367

Change 141367 abandoned by TheDJ:
Link dialog: do basic URI validation

Reason:
No reviewers willing to review

https://gerrit.wikimedia.org/r/141367

Change 141367 had a related patch set uploaded (by Paladox):
Link dialog: do basic URI validation

https://gerrit.wikimedia.org/r/141367

Change 552359 had a related patch set uploaded (by Happy5214; owner: Happy5214):
[mediawiki/extensions/WikiEditor@master] Link dialog: do basic URI validation

https://gerrit.wikimedia.org/r/552359