Page MenuHomePhabricator
Create Task
Maniphest T307897

Fix typo in telemetry config
Closed, ResolvedPublic
Actions

Description

TimerLastEmmitedEvent -> TimerLastEmittedEvent
"_timer_last_emmited_event" -> "_timer_last_emitted_event"

Will need to do this change in stages, see: https://gitlab.wikimedia.org/repos/releng/cli/-/merge_requests/184#note_6550

Event Timeline

Ollie.Shotton_WMDE created this task.May 9 2022, 9:24 AM
Addshore claimed this task.Feb 10 2023, 5:59 PM
Addshore moved this task from Backlog to In Progress on the mwcli board.
Addshore added a comment.Feb 10 2023, 6:04 PM

So I unintentionally "fixed" the second one of these typos in https://gitlab.wikimedia.org/repos/releng/cli/-/commit/048da93951643b0134fae98532d2f24d5aafdc95 when I added misspell
This is the one that should have been nicely migrated, (whoops)
This was in v0.15.0...

I'll fix the other one now and also add something that should remove leftover _timer_last_emmited_event vars in the config...

Addshore added a comment.Feb 10 2023, 6:08 PM

Oh, looks like the way the config is handeled, unknown values will auto be cleaned up anyway...

Addshore moved this task from In Progress to Review on the mwcli board.Feb 10 2023, 6:08 PM

!303 Fix TimerLastEmmitedEvent typo (fix-TimerLastEmmitedEvent-typo)
https://gitlab.wikimedia.org/repos/releng/cli/-/merge_requests/303

Addshore moved this task from Review to Pending Release on the mwcli board.Feb 10 2023, 10:30 PM
Addshore closed this task as Resolved.Feb 13 2023, 1:54 PM
Addshore moved this task from Pending Release to Done on the mwcli board.

v0.20.0 is currently releasing

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL