As part of the Elasticsearch 7.10 upgrade, we need to ensure that all tests are passing.
AC:
- all tests are green when run against Elasticsearch 7.10
Description
Description
Details
Details
Related Changes in Gerrit:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T248925 Make MediaWiki release tarball compatible with PHP 8.0 | |||
| Resolved | Jdforrester-WMF | T300463 Make PHP 8.0 voting on MW master | |||
| Resolved | None | T283275 Make MW master tests pass on PHP 8.0 | |||
| Resolved | Reedy | T268861 CirrusSearch uses Elastica's Match class | |||
| Resolved | Reedy | T268863 Translate uses Elastica's Match class | |||
| Resolved | matthiasmullie | T268866 WikibaseMediaInfo uses Elastica's Match class | |||
| Invalid | None | T268864 WikibaseCirrusSearch uses Elastica's Match class | |||
| Resolved | Reedy | T268865 WikibaseLexemeCirrusSearch uses Elastica's Match class | |||
| Resolved | EBernhardson | T271777 Bump rufin/elastica (and related libraries) to versions that support PHP 8.0 | |||
| Resolved | Gehel | T263142 [EPIC] Upgrade Elasticsearch to version 7.10 | |||
| Resolved | EBernhardson | T307931 Run CirrusSearch test suite against Elasticsearch 7.10 |
Event Timeline
Comment Actions
The first blocker is that the test query d*e*a*d*l*y*w*i*l*d*c*a*r*d runs when we expected it to be failed as too-complex. Bisecting the elasticsearch codebase finds that while fixing wildcard queries a regression was introduced that no longer checks the max determinized states. Likely the fix is going to have to be a hack on the CirrusSearch side to disallow creating queries with more than a couple *'s
Comment Actions
Change 790622 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/CirrusSearch@es710] Prevent pathological wildcard queries to reach the backend
Comment Actions
Change 791357 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/CirrusSearch@master] Prevent pathological wildcard queries to reach the backend
Comment Actions
Change 790622 abandoned by DCausse:
[mediawiki/extensions/CirrusSearch@es710] Prevent pathological wildcard queries to reach the backend
Reason:
moved to master
Comment Actions
Change 791357 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Prevent pathological wildcard queries to reach the backend