Page MenuHomePhabricator

Run CirrusSearch test suite against Elasticsearch 7.10
Closed, ResolvedPublic

Description

As part of the Elasticsearch 7.10 upgrade, we need to ensure that all tests are passing.

AC:

  • all tests are green when run against Elasticsearch 7.10

Event Timeline

The first blocker is that the test query d*e*a*d*l*y*w*i*l*d*c*a*r*d runs when we expected it to be failed as too-complex. Bisecting the elasticsearch codebase finds that while fixing wildcard queries a regression was introduced that no longer checks the max determinized states. Likely the fix is going to have to be a hack on the CirrusSearch side to disallow creating queries with more than a couple *'s

Change 790622 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@es710] Prevent pathological wildcard queries to reach the backend

https://gerrit.wikimedia.org/r/790622

Change 791357 had a related patch set uploaded (by DCausse; author: DCausse):

[mediawiki/extensions/CirrusSearch@master] Prevent pathological wildcard queries to reach the backend

https://gerrit.wikimedia.org/r/791357

Change 790622 abandoned by DCausse:

[mediawiki/extensions/CirrusSearch@es710] Prevent pathological wildcard queries to reach the backend

Reason:

moved to master

https://gerrit.wikimedia.org/r/790622

Change 791357 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Prevent pathological wildcard queries to reach the backend

https://gerrit.wikimedia.org/r/791357

tests run and pass with the browser bot running 7.10.2