Page MenuHomePhabricator

Verify that Upload by URL and job runners is not affected by ChronologyProtector fix
Closed, ResolvedPublic


Bug 27891 was fixed by r87235 which removed session_write_close() so it wouldn't disturb ChronologyProtector. Tim has already put a FIXME on r72475, but I'm opening this bug so that I can track this issue.

Version: 1.18.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:32 PM
bzimport set Reference to bz28794.

Bryan.TongMinh wrote:

The affected component is not UploadStash, but asynchronous upload-by-url. Or more generally, job runners that access the session and that are run at the end of a normal request rather than via runJobs.php. It is possible that they will destroy the current session, but I need to look into the code to verify that.

Bryan, have you had a chance to look at this yet? Results?

fixme has been marked resolved 3 days ago.