Page MenuHomePhabricator

Add missing ARIA labels to fields in VE maps dialog
Closed, ResolvedPublic1 Estimated Story Points

Description

Add missing ARIA labels to fields in the VE maps dialog. These have been identified as missing labels:

  • size field - use field labels width and height

Screenshot from 2022-05-04 14-24-30.png (365×1 px, 81 KB)

  • language input field - use field label (Language)

Screenshot from 2022-05-04 14-45-14.png (348×1 px, 79 KB)

  • … button - label: Select language (Use the pop up's header, so if that ever changes, the ARIA label would auto update.)

Screenshot from 2022-05-04 14-46-24.png (406×1 px, 79 KB)

Event Timeline

Lena_WMDE renamed this task from Add missing ARIA labels to fields in VE to Add missing ARIA labels to fields in VE maps dialog.May 10 2022, 11:56 AM
Lena_WMDE added a project: Maps (Kartographer).
Lena_WMDE added a project: VisualEditor.

Change 791592 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[VisualEditor/VisualEditor@master] Add missing ARIA labels to dimension fields in VE maps dialog

https://gerrit.wikimedia.org/r/791592

  • size field - use field label (Size)

@ECohen_WMDE I think using the direct description of the contents for each field is more precise. So instead of using size for both I would use width and height.

  • … button - label: Select language (Can you use the pop up's header? So if that ever changes, the ARIA label would auto update?)

Good idea. Should not be a problem.

Change 791593 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/VisualEditor@master] Add missing ARIA labels to dimension fields in VE maps dialog

https://gerrit.wikimedia.org/r/791593

@ECohen_WMDE I think using the direct description of the contents for each field is more precise. So instead of using size for both I would use width and height.

Good point. Sounds good!

@ECohen_WMDE There has been some back-and-forth in Gerrit, so I want to double-check with you that we're adding an aria-label here and not a title?

@ECohen_WMDE There has been some back-and-forth in Gerrit, so I want to double-check with you that we're adding an aria-label here and not a title?

If I get it right from the discussion on the patch, the main issue with using a title attribute is, that it's not working for touch and keyboard users. So the risk is to assume the situation got better with just adding title attribute, but in reality it's still bad for certain user groups.

There's kind of a second discussion in there that's about title not working well for screen reader users. But from my experiments that's not true. At least not when applied to form fields. We can still add aria-label and title. When the content is identical it won't be read twice (from my experiments).

For me it comes down to the question if we 'just' want to implement better support for screen readers or if we also want to make the situation slightly better for mouse users (while being aware that there's still room for improvements).

Okay after or little talk in the daily this morning, I realized, that this task originally was never about make it better for non screenreader users and the screencasts were not part of the requirements :-D.

We still could easily do both with the suggested implementation, but if we want to keep it simple and avoid more hassle, maybe we should just add aria-label.

lilients_WMDE changed the point value for this task from 3 to 1.Aug 3 2022, 8:45 AM

We still could easily do both with the suggested implementation, but if we want to keep it simple and avoid more hassle, maybe we should just add aria-label.

I would keep it simple for now then and add the aria-label. Is this stalled because it was waiting for my review or is it something else?

I would keep it simple for now then and add the aria-label. Is this stalled because it was waiting for my review or is it something else?

No all good. Waiting on review from WMF folks. We do not have merge rights there. The current implementation just adds the aria-label. So it should be uncontroversial.

Change 791592 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Add missing ARIA labels to fields in VE maps dialog

https://gerrit.wikimedia.org/r/791592

Change 791593 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (439831778)

https://gerrit.wikimedia.org/r/791593

Sorry for the late response, I didn't realize you were waiting for me.

Sorry for the late response, I didn't realize you were waiting for me.

All good, the urgency was not that high anyways. Thanks for the finishing move though!

WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2022-08-17 board.