Page MenuHomePhabricator

Make all VE maps dialog interactive elements reachable by tab key
Closed, InvalidPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Open the VE interface of Kartographer.
  • Use the tab key to access all elements.

Screenshot from 2022-05-04 14-35-06.png (981×1 px, 120 KB)

What happens?:

  • Maps content and Options currently not reachable via tab.

Screenshot from 2022-05-04 14-57-15.png (1×1 px, 139 KB)

What should have happened instead?:
All element should be reachable via tab.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Kartographer

Event Timeline

Lena_WMDE renamed this task from Make all dialog tabs reachable by tab key to Make all VE maps dialog tabs reachable by tab key.May 10 2022, 11:55 AM
ECohen_WMDE renamed this task from Make all VE maps dialog tabs reachable by tab key to Make all VE maps dialog interactive elements reachable by tab key.May 10 2022, 1:32 PM
DLynch subscribed.

This is a OOUI TabSelectWidget question, more than something VE-specific. As it works currently, you focus the widget, and then you can navigate between tabs with arrow keys (i.e. this is keyboard-reachable, with the right mental model). I'm sure this behavior is changeable, but we should watch out for side effects in various places that're using TabSelectWidget.

thiemowmde subscribed.

"Map area", "Map contents" and "Options" are tabs. These can be switched with the cursor keys. This is standard OOUI behavior.

There are certainly ways to change this. We suggest to open a new ticket in case this turns out to be necessary. This one here was about stuff being unreachable.

Thanks for the hint about the OOUI behaviour. Seems okay to me that they are reachable with the cursor keys (and not via tab). The only issue that remains in this use case is, that the focus is being caught in the input fields when you arrow key to another tab (which is not happening in the OOUI demo). This way it is impossible to get to the next tab (click to view screencast):

Peek 2023-06-13 16-12.gif (1×1 px, 746 KB)

@thiemowmde Do you think it makes sense to reopen this ticket and try to find a solution for that? Maybe by removing the autofocus of the input field?

Yes, let's create a dedicated OOUI ticket for this issue. I tried to dig into it yesterday and I think it's a general issue with the widget, even if the demo page https://doc.wikimedia.org/oojs-ui/master/demos/?page=layouts&theme=wikimediaui&direction=ltr&platform=desktop#IndexLayout-framed doesn't show it. I think that's simply because the tabs in the demo are empty.