Fix Chinese translation for modernized wiktionary.org and wikibooks.org portals
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Diskdance
	May 10 2022, 11:36 AM

Description

The new Wiktionary portal at https://www.wiktionary.org show English text to Chinese users. It is supposed to show Simp/Trad Chinese translation instead.

Developer note

In contrast to wikt portal, for wikipedia.org:

zh is already on the top10
for browsers without a zh locale, display both simp and trad to them
for browsers with a zh locale, display variants as following:
- zh, zh-hans, zh-cn, zh-my, zh-sg: zh-hans.json
- zh-hant, zh-tw, zh-mo, zh-hk: zh-hant.json

In wiktionary.org and wikibooks.org portal, zh is not on top10, thereby it can only be load through ajax when we detect a zh locale.

Details

Subject	Repo	Branch	Lines +/-
Fix the top 10 featured language for Chinese sites	wikimedia/portals	master	+189 -637
Handle zh translation properly for wiktionary and wikibooks portal	wikimedia/portals	master	+113 -12
Fix l10n problems for Chinese in Wikimedia portals	wikimedia/portals	master	+302 -207

Customize query in gerrit

Related Objects

Mentioned In: T355001: Chinese Wikinews is missing on the Wikinews.org portal because the slogan translation was deleted
T273179: Update the front-page of Wikimedia projects
Mentioned Here: T311361: Migrate away from unmaintained dependencies in portals' codebase

Event Timeline

Diskdance created this task.May 10 2022, 11:36 AM

Restricted Application added subscribers: Ericliu1912, Aklapper. · View Herald TranscriptMay 10 2022, 11:36 AM

TheresNoTime subscribed.May 10 2022, 12:10 PM

I mean, basically every sister project portal besides Wikipedia.org does not have proper translation at this point, so...

And also, their appearances should all be updated respectively as Wikipedia.org and Wiktionary.org look like, if could.

Change 790724 had a related patch set uploaded (by Tranve; author: Tranve):

[wikimedia/portals@master] Fix l10n problems for Chinese in Wikimedia portals

https://gerrit.wikimedia.org/r/790724

gerritbot added a project: Patch-For-Review.May 10 2022, 4:37 PM

Diskdance updated the task description. (Show Details)May 11 2022, 12:28 PM

Diskdance updated the task description. (Show Details)May 11 2022, 1:20 PM

Diskdance updated the task description. (Show Details)

Diskdance renamed this task from Fix Chinese translation for new wiktionary.org portal to Fix Chinese translation for modernized wiktionary.org and wikibooks.org portals.May 15 2022, 12:49 AM

Diskdance updated the task description. (Show Details)

Change 791769 had a related patch set uploaded (by Tranve; author: Tranve):

[wikimedia/portals@master] Generate and show zh translations properly

https://gerrit.wikimedia.org/r/791769

Change 790724 abandoned by Tranve:

[wikimedia/portals@master] Fix l10n problems for Chinese in Wikimedia portals

Reason:

Abandon in favor of 791769

https://gerrit.wikimedia.org/r/790724

Diskdance mentioned this in T273179: Update the front-page of Wikimedia projects.May 26 2022, 10:50 AM

Change 791769 merged by jenkins-bot:

[wikimedia/portals@master] Handle zh translation properly for wiktionary and wikibooks portal

https://gerrit.wikimedia.org/r/791769

Patch 1 merged. The next step is to make top-viewed wikis correctly arranged according to users' locale.

Maintenance_bot removed a project: Patch-For-Review.May 26 2022, 12:30 PM

@Jdrewniak Sorry to interrupt, but can I use ES6 features like arrow functions, Promise and fetch() in portals' code?
I have encountered a problem that, there is an asynchronous XHR in topten-localized.js and we must ensure that its execution is completed before that of PerformChineseConversion(), but it is not easy to achieve the effect.
I think the best approach is to convert code in topten-localized.js and page-localized.js to use Promise chains, which are not supported in IE11. Since IE11 has got its special treatment, can we just break support of it and use those modern stuffs? Thanks.

Most of translation problems have been fixed now, but it is still problematic when Chinese is not in the top10 area. To fix this some abstraction and cleaning up is needed. See T311361.

Winston_Sung moved this task from Backlog to Apps/Tools/Services on the Chinese-Sites board.Feb 3 2023, 12:02 PM

Diskdance removed Diskdance as the assignee of this task.Jan 12 2024, 2:01 PM

Func mentioned this in T355001: Chinese Wikinews is missing on the Wikinews.org portal because the slogan translation was deleted.Jan 22 2024, 1:54 PM

Change 992961 had a related patch set uploaded (by Func; author: Func):

[wikimedia/portals@master] Fix the top 10 featured language for Chinese sites

https://gerrit.wikimedia.org/r/992961

gerritbot added a project: Patch-For-Review.Jan 26 2024, 12:30 PM

Change 992961 merged by jenkins-bot:

[wikimedia/portals@master] Fix the top 10 featured language for Chinese sites

https://gerrit.wikimedia.org/r/992961

Func removed a project: Patch-For-Review.Jan 31 2024, 9:44 AM

Func closed this task as Resolved.Feb 12 2024, 6:30 AM