I can trigger it if I put a plus sign in an street address or city. Maybe we can filter those out completely?

If we're removing the address fields from the dlocal form completely (see T308464) that will also fix it, but I feel like we should add the + sign scrubbing as well in case they are used elsewhere.

Change 800033 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Filter out + signs from DLocal address fields

https://gerrit.wikimedia.org/r/800033

Still seeing the invalid control error and there is no address from request field that can screwed up the signature.{"id":"120123033","ts":"20220610121743","referrer":"en.wikipedia.org\/","utm_source":"B2122_0527_enZA_dsk_p1_lg_txt_109.no-LP.cc","utm_medium":"sitenotice","utm_campaign":"C2122_enZA_dsk_FR","utm_key":"otherAmt_1~ptf_1~vw_1920~vh_969~time_22","language":"en","country":"ZA","form_amount":"ZAR 1248.00","payments_form":"astropay.JimmyQuote","source_name":"DonationInterface","source_type":"payments","source_host":"payments1006","source_run_id":3966,"source_version":"8c6208c25c1f66ee67bfc7ef975b4e5b9051aebb","source_enqueued_time":1654863463}

I'm not finding that one specifically, but I do still see some instances of that error, all from donors who use a + sign in their email address. We can collect their full email address for ourselves and just send DLocal a version with everything from the + sign to the @ sign stripped out.

OK, patch is updated to handle email addresses as proposed in the previous comment.

Change 808986 had a related patch set uploaded (by AndyRussG; author: AndyRussG):

[mediawiki/extensions/DonationInterface@master] Remove removal of "+" symbols in AstroPay signature

https://gerrit.wikimedia.org/r/808986

Change 800033 abandoned by Ejegg:

[mediawiki/extensions/DonationInterface@master] Filter out + signs from DLocal address fields

Reason:

AndyRussG found a simpler way to fix it

https://gerrit.wikimedia.org/r/800033

Change 808986 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Remove removal of "+" symbols in AstroPay signature

https://gerrit.wikimedia.org/r/808986