Page MenuHomePhabricator
Create Task
Maniphest T308173

MediaSearch should not interfere with opening images in a new window via ctrl-click / shift-click
Closed, ResolvedPublicBUG REPORT
Actions

Description

Not being able to open search results in separate windows by clicking on them is a productivity hit, and I don't think there's any drawback to the opposite behavior. The click handler that manages the preview window should pass through clicks with a modifier key pressed.

Details

SubjectRepoBranchLines +/-
Only show media details on a plain left, unmodified clickmediawiki/extensions/MediaSearchmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 11 2022, 6:44 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMay 11 2022, 6:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
CBogen moved this task from Triage to MediaSearch on the Structured-Data-Backlog board.May 16 2022, 4:35 PM
gerritbot added a comment.Sep 19 2023, 8:43 PM

Change 959054 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/MediaSearch@master] Only show media details on a plain left, unmodified click

https://gerrit.wikimedia.org/r/959054

gerritbot added a project: Patch-For-Review.Sep 19 2023, 8:43 PM
gerritbot added a comment.Sep 28 2023, 8:11 PM

Change 959054 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Only show media details on a plain left, unmodified click

https://gerrit.wikimedia.org/r/959054

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 8:30 PM
Tgr added a comment.Sep 29 2023, 5:52 AM

(see also T328251: Vector 2022 search dropdown should not copy the value when opening it in a new window)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 29 2023, 10:01 AM
TheDJ closed this task as Resolved.Oct 6 2023, 11:20 AM
TheDJ claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL