Page MenuHomePhabricator
Create Task
Maniphest T308191

Remove oggThumb from TMH
Closed, ResolvedPublic
Actions

Description

I suggest we remove oggThumb from TimedMediaHandler. This tool was used in the past because it avoided problems with frame selection that ffmpeg had with ogg/theora, but these issues have long since been fixed.

As far as I'm aware, WMF does not use this any longer and relies solely on ffmpeg and I doubt anyone else has a reason to use it.

Details

SubjectRepoBranchLines +/-
Remove unused OggThumbLocation config variableoperations/mediawiki-configmaster+0 -2
Remove unused oggthumblocation variablemediawiki/extensions/CirrusSearchmaster+0 -1
Remove unused oggThumbmediawiki/extensions/TimedMediaHandlermaster+1 -82
Customize query in gerrit

Event Timeline

TheDJ created this task.May 11 2022, 9:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2022, 9:17 PM
gerritbot added a comment.May 11 2022, 9:39 PM

Change 791084 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Remove unused oggThumb

https://gerrit.wikimedia.org/r/791084

gerritbot added a project: Patch-For-Review.May 11 2022, 9:39 PM
TheDJ claimed this task.May 11 2022, 9:40 PM
TheDJ triaged this task as Medium priority.
gerritbot added a comment.May 12 2022, 9:39 PM

Change 791084 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Remove unused oggThumb

https://gerrit.wikimedia.org/r/791084

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 12 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 12 2022, 10:30 PM
TheDJ closed this task as Resolved.May 12 2022, 11:19 PM
gerritbot added a comment.May 13 2022, 1:12 PM

Change 791603 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/CirrusSearch@master] Remove unused oggthumblocation variable

https://gerrit.wikimedia.org/r/791603

gerritbot added a project: Patch-For-Review.May 13 2022, 1:12 PM
gerritbot added a comment.May 13 2022, 1:14 PM

Change 791605 had a related patch set uploaded (by TheDJ; author: TheDJ):

[operations/mediawiki-config@master] Remove unused OggThumbLocation config variable

https://gerrit.wikimedia.org/r/791605

TheDJ reopened this task as Open.May 13 2022, 1:15 PM
TheDJ added a project: User-TheDJ.

Lets keep this open until the other patches are merged

gerritbot added a comment.May 13 2022, 2:06 PM

Change 791603 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Remove unused oggthumblocation variable

https://gerrit.wikimedia.org/r/791603

gerritbot added a comment.May 23 2022, 6:34 AM

Change 791605 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused OggThumbLocation config variable

https://gerrit.wikimedia.org/r/791605

Stashbot added a comment.May 23 2022, 6:35 AM

Mentioned in SAL (#wikimedia-operations) [2022-05-23T06:35:22Z] <ladsgroup@deploy1002> Synchronized wmf-config/CommonSettings.php: Config: [[gerrit:791605|Remove unused OggThumbLocation config variable (T308191)]] (duration: 00m 51s)

Maintenance_bot removed a project: Patch-For-Review.May 23 2022, 7:30 AM
TheDJ closed this task as Resolved.May 23 2022, 9:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL