Page MenuHomePhabricator

Suggested edits: Topic filters are not applied when showing the task feed in the post-edit dialog
Closed, ResolvedPublicBUG REPORT

Description

This is a bug surfaced in T302335: Suggested edits: show the full task feed on post-edit dialog.

List of steps to reproduce (step by step, including full links if applicable):

  • Select one or more topics
  • Complete a suggested edit

What happens?:
When the post-edit dialog is shown, there are more tasks than shown in the suggested edits module since the topic selection isn't applied.

What should have happened instead?:
There should be n - 1 tasks in the post-edit dialog (where n is the number of tasks in the suggested edits module).

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:

Event Timeline

mewoph updated the task description. (Show Details)
mewoph updated the task description. (Show Details)

Change 791088 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: always output config vars needed by ext.growthExperiments.DataStore

https://gerrit.wikimedia.org/r/791088

The issue is that when fetching tasks for the post-edit dialog, we are checking whether topics are enabled by checking the JS config var GEHomepageSuggestedEditsEnableTopics. However, this config var is only outputted in the homepage. Now that the task feed is shown outside the homepage, this config var should always be outputted.

With fix:

HomepagePost-edit dialog
Screen Shot 2022-05-11 at 2.48.05 PM.png (858×1 px, 542 KB)
Screen Shot 2022-05-11 at 2.49.26 PM.png (958×1 px, 217 KB)
kostajh triaged this task as High priority.May 12 2022, 8:57 AM

Change 791088 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: always output config vars needed by ext.growthExperiments.DataStore

https://gerrit.wikimedia.org/r/791088

Etonkovidova updated the task description. (Show Details)
Etonkovidova subscribed.

Checked in testwiki wmf.12 - works as expected.