Page MenuHomePhabricator
Create Task
Maniphest T308195

Moving focus while link context is visible does not close it
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Esanders
May 11 2022, 11:38 PM
Tags
Referenced Files
F35219029: image.png
Jun 8 2022, 2:29 PM
F35219021: image.png
Jun 8 2022, 2:29 PM
F35132108: image.png
May 11 2022, 11:40 PM
Subscribers
Aklapper
Esanders
matmarex

Description

  1. Open reply tool on mobile
  2. Expand the 'Advanced' section
  3. In the reply tool, add a link and focus it so the link context is visible
  4. Focus the "Summary" field

Observe the link context is still visible:

image.png (677×426 px, 33 KB)

Expected:
The link context closes when the summary input is focused.

We use ce.Surface "deactivation" to support the link context on mobile, however by design the surface will not blur in response to any focus change while it is deactivated.

The same issue can be reproduced in other VE integrations:

Article editor (move focus to site search):Flow (move focus to another reply area):
image.png (548×431 px, 41 KB)
image.png (733×513 px, 33 KB)

Related Objects

Event Timeline

Esanders created this task.May 11 2022, 11:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2022, 11:38 PM
Esanders updated the task description. (Show Details)May 11 2022, 11:40 PM
ppelberg added a parent task: T298055: [RELEASE TICKET] Offer Mobile Usability Improvements and Topic Subscriptions at Partner Wikis.May 19 2022, 3:17 PM
ppelberg added a project: Editing-team (Kanban Board).
ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.May 19 2022, 3:47 PM
matmarex subscribed.May 19 2022, 9:06 PM

Previously discussed in the context of desktop: T255292: Node description is hard to dismiss.

VPuffetMichel edited projects, added Editing-team; removed Editing-team (Kanban Board).Jun 6 2022, 7:20 PM
VPuffetMichel moved this task from Kanban Board to Upcoming on the Editing-team board.
Esanders added a comment.Jun 7 2022, 11:17 PM

T255292 is similar, but the problem here is that we stop listening to blur events completely once the surface is deactivated.

Esanders added a comment.EditedJun 8 2022, 2:23 PM

To fix this we would either need to distinguish between focus leaving the document for something still within the editor, e.g. the input of a link inspector in VE desktop, and focus leaving the document for another control (the edit summary input here). Currently no such distinction exists, and if we were to star blurring the document when a deactivated focus went to certain places, we would need to check there weren't any false positives (e.g. focus temporarily landing on <body> in some slightly broken browser, or an input that's part of an inspector, but attached to some part of the DOM we don't consider the editor)

Esanders updated the task description. (Show Details)Jun 8 2022, 2:29 PM
matmarex mentioned this in T255292: Node description is hard to dismiss.Jul 19 2022, 7:29 PM
matmarex added a comment.Apr 6 2023, 1:37 PM

It looks like we have fixed this in the desktop version, but not on mobile.

matmarex removed a parent task: T298055: [RELEASE TICKET] Offer Mobile Usability Improvements and Topic Subscriptions at Partner Wikis.Apr 6 2023, 1:37 PM
Esanders added a comment.Apr 19 2023, 11:50 AM
In T308195#8762555, @matmarex wrote:

It looks like we have fixed this in the desktop version, but not on mobile.

I don't think this was ever broken on desktop.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits