Page MenuHomePhabricator

Mobile DiscussionTools' toolbar appears atop link card
Closed, ResolvedPublic

Description

This task involves the work with introducing some kind of visual priority such that the toolbar within mobile DiscussionTools (Reply and New Topic Tool) do not appear within the mobile link card.

Behavior

  1. Visit the following link on a mobile device/using the mobile site: https://ht.wikipedia.org/wiki/Diskisyon_Itilizat%C3%A8:PPelberg_(WMF)
  2. Open the Reply or New Topic Tool
  3. Insert a link
  4. Tap the link you inserted in "3."
  5. Scroll the page

Actual

  1. ❗️Notice the tool you opened in "2." 's toolbar appear within the link card:
Reply ToolNew Topic Tool
Screen Shot 2022-05-11 at 6.24.55 PM.png (1×774 px, 250 KB)
Screen Shot 2022-05-11 at 6.25.18 PM.png (1×792 px, 100 KB)

Expected

  1. ✅ The Reply and New Topic Tools' toolbars do NOT appear within the link card

Done

  • Expected behavior is implemented

Event Timeline

Change 791403 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Ensure mobile context appears above toolbar on mobile

https://gerrit.wikimedia.org/r/791403

Change 791403 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Ensure mobile context appears above toolbar on mobile

https://gerrit.wikimedia.org/r/791403

Change 791698 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f07b7e2cf)

https://gerrit.wikimedia.org/r/791698

Change 791698 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f07b7e2cf)

https://gerrit.wikimedia.org/r/791698

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.

This works fine. See https://photos.app.goo.gl/kT8S9Q2Ukyu5WZpY9.

Outside the context of the toolbar, I made an observation(00:24) -> Should the button label be "Leave a comment"? I think "Abandon comment" or something similar fits the action description better. Just my though.

Outside the context of the toolbar, I made an observation(00:24) -> Should the button label be "Leave a comment"? I think "Abandon comment" or something similar fits the action description better. Just my though.

image.png (1×788 px, 486 KB)

It looks like you're using Google Translate, and this is just a bad automatic translation. The English interface has "Discard comment" instead.

Outside the context of the toolbar, I made an observation(00:24) -> Should the button label be "Leave a comment"? I think "Abandon comment" or something similar fits the action description better. Just my though.

image.png (1×788 px, 486 KB)

It looks like you're using Google Translate, and this is just a bad automatic translation. The English interface has "Discard comment" instead.

This makes better sense. Thanks!