Page MenuHomePhabricator
Create Task
Maniphest T308212

SX Block Template Adaptation: "No equivalent template" card is displayed until template translation is loaded
Closed, ResolvedPublic
Actions

Description

As it is demonstrated in the below screencast, when a block template is being translated inside "Pick a sentence" step, the card for "No equivalent template" is displayed until the translation is loaded. This can be misleading for the users, especially in cases when translation takes some time to be loaded. Instead of the "No equivalent template" banner, a loading indicator should be displayed to let users know that the translation is still being loaded.

Screen Recording 2022-05-12 at 11.26.44 AM.mp4446 KBDownload

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20220516mediawiki/extensions/ContentTranslationmaster+69 -65
SX block templates: Fix spinner to be displayed until translation is loadedmediawiki/extensions/ContentTranslationmaster+4 -2
Customize query in gerrit

Event Timeline

ngkountas created this task.May 12 2022, 8:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2022, 8:32 AM
ngkountas triaged this task as Medium priority.May 12 2022, 8:33 AM
ngkountas moved this task from Priority: SX Adoption to In Review on the Language-Team (Language-2022-April-June) board.
gerritbot added a comment.May 12 2022, 8:33 AM

Change 790740 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX block templates: Fix spinner to be displayed until translation is loaded

https://gerrit.wikimedia.org/r/790740

gerritbot added a project: Patch-For-Review.May 12 2022, 8:33 AM
gerritbot added a comment.May 12 2022, 10:04 AM

Change 790740 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX block templates: Fix spinner to be displayed until translation is loaded

https://gerrit.wikimedia.org/r/790740

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 12 2022, 12:00 PM
gerritbot added a comment.May 16 2022, 5:21 AM

Change 791830 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220516

https://gerrit.wikimedia.org/r/791830

gerritbot added a comment.May 16 2022, 10:44 AM

Change 791830 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220516

https://gerrit.wikimedia.org/r/791830

• santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2022-April-June) board.May 24 2022, 4:04 AM
EChukwukere-WMF subscribed.EditedJun 20 2022, 3:13 PM

Testing status: QA PASS

Using the above stated article and similar article the template loads up in a timely fashion and prevents users from seeing the erroneous no template message

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-April-June) board.Jun 20 2022, 3:15 PM
Pginer-WMF closed this task as Resolved.Jul 1 2022, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL