Page MenuHomePhabricator

Betacommons: I have 99+ new alerts except not really it's only 25, except it's really 99+
Closed, DuplicatePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • I suspect you need to have >25 new talk page messages.

What happens?:
Animated gif:

betacommons 99 new messages except not really.gif (471×1 px, 51 KB)

What should have happened instead?:
You have 25 new messages Notifications should show all new talk page messages, or indicate there's more than 25

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

What does "all notifications" show, just out of interest?

AlexisJazz renamed this task from Betacommons: I have 99+ new alerts except not really it's only 25 to Betacommons: I have 99+ new alerts except not really it's only 25, except it's really 99+.May 12 2022, 12:37 PM
AlexisJazz updated the task description. (Show Details)

What does "all notifications" show, just out of interest?

Hmm, of course.. I really DO have 99+ new talk page messages! I've been testing there with my main account. There's way more than 25 and Special:Notifications is full of "AJ‬ left a message on your talk page in..", all with a blue circle.

So the question is, why did it say 25? Just a guess: the flyout previews are capped at 25, so the number is the number of previews, not the actual number of new talk page messages.

As @AlexisJazz mentions above, this is due to the notifications API call made having a limit set (notlimit=25, from mw.echo.api.EchoApi.js I think?), and bundling related notifications (notbundle=1) (API docs)

{P27831, highlight=19-44}

A possible solution is to use the true count (P27831$48) in the notificationItemWidget header, but I'm not sure how that would be affected by notification type bundling..

To replicate:

  1. Make 25+ edits using an alternative account to your user talk page (i.e. this)
  2. On your primary account, note the value of the mw-echo-notifications-badge
  3. Click on the echo "bell" icon, note the value given in mw-echo-ui-notificationItemWidget-content-message-header
  4. Click Expand, note the number of returned notifications
  5. Click All notifications (or go to Special:Notifications), note that all notifications are returned as expected

Screenshots