The zero results has some visual regression from how it should look as specified with a white footer background here.
Expected | Actual |
RHo | |
May 12 2022, 1:04 PM |
F35152614: IMG_0944.PNG | |
May 18 2022, 11:16 PM |
F35152627: IMG_0944.PNG | |
May 18 2022, 11:16 PM |
F35152607: IMG_0943.PNG | |
May 18 2022, 11:16 PM |
F35152617: IMG_0945.PNG | |
May 18 2022, 11:16 PM |
F35152609: IMG_0942.PNG | |
May 18 2022, 11:16 PM |
F35138697: Screen Shot 2022-05-13 at 10.01.02 AM.png | |
May 13 2022, 5:02 PM |
F35131471: Screenshot_20220511-131239_Chrome.jpg | |
May 12 2022, 1:04 PM |
F35134833: image.png | |
May 12 2022, 1:04 PM |
The zero results has some visual regression from how it should look as specified with a white footer background here.
Expected | Actual |
Change 791643 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: update footer background color for LastDayEditsWidget
Change 791643 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Suggested edits: update footer background color for LastDayEditsWidget
Moving for @RHo to take a quick look - seems all fine to me. There seems to be a small issue (unrelated to this task) for RTL where the text "edits in the last days" is place a little too tight to the image
.Checked for wmf.12 deployment (group 1):
cawiki wmf.12 | hewiki wmf.12 |
---|---|
enwiki wmf.10 | arwiki wmf.10 |
---|---|
Thanks @Etonkovidova - agree this is a different RTL issue which I've filed as T308846. I have a funny feeling this may be regression as I swear we fixed this before.
Checked for wmf.12 deployment (group 1):
- with the fix
cawiki wmf.12 hewiki wmf.12
- the fix is not deployed yet (for comparison purposes)
enwiki wmf.10 arwiki wmf.10