Page MenuHomePhabricator
Create Task
Maniphest T308243

WikibaseLexeme CI broken: Phan no longer aware of Scribunto classes
Closed, ResolvedPublic
Actions

Description

In T308210, we removed Wikibase’s Phan stubs, but WikibaseLexeme was using those as well. We need to update WikibaseLexeme’s Phan config to point to the real Scribunto, and also update the integration config to add Scribunto to WikibaseLexeme’s Phan dependencies (WikibaseLexeme depends on Wikibase, and Wikibase depends on Scribunto, but the Phan dependencies aren’t transitive).

Details

SubjectRepoBranchLines +/-
Update .phan/config.php for Wikibase stub changesmediawiki/extensions/WikibaseLexememaster+2 -2
Update .phan/config.php for Wikibase stub changesmediawiki/extensions/WikibaseManifestmaster+2 -2
Update .phan/config.php for Wikibase stub changesmediawiki/extensions/WikibaseCirrusSearchmaster+2 -1
Update .phan/config.php for Wikibase stub changesmediawiki/extensions/WikibaseLexemeCirrusSearchmaster+2 -1
Update .phan/config.php for Wikibase stub changesmediawiki/extensions/ArticlePlaceholdermaster+0 -8
zuul: Add Scribunto to more Phan dependenciesintegration/configmaster+5 -4
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 12 2022, 1:30 PM
gerritbot added a comment.May 12 2022, 1:31 PM

Change 791375 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[integration/config@master] zuul: Add Scribunto to WikibaseLexeme Phan dependencies

https://gerrit.wikimedia.org/r/791375

gerritbot added a project: Patch-For-Review.May 12 2022, 1:31 PM

Change 791370 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791370

Lucas_Werkmeister_WMDE triaged this task as High priority.May 12 2022, 1:32 PM

Marking this as high priority, but not UBN, since (I think) it only affects one extension.

Lucas_Werkmeister_WMDE added a comment.EditedMay 12 2022, 1:34 PM

Hrm, but Codesearch reveals the following extensions were also using Wikibase/.phan/stubs:

  • ArticlePlaceholder correction, is not using Wikibase stubs, already uses real Scribunto
  • WikibaseCirrusSearch
  • WikibaseLexemeCirrusSearch
  • WikibaseManifest

It’s probably best to repurpose this task to cover all of them?

gerritbot added a comment.May 12 2022, 1:41 PM

Change 791378 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791378

gerritbot added a comment.May 12 2022, 1:41 PM

Change 791379 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791379

gerritbot added a comment.May 12 2022, 1:41 PM

Change 791380 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseManifest@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791380

gerritbot added a comment.May 12 2022, 2:30 PM

Change 791383 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ArticlePlaceholder@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791383

gerritbot added a comment.May 12 2022, 2:56 PM

Change 791375 merged by jenkins-bot:

[integration/config@master] zuul: Add Scribunto to more Phan dependencies

https://gerrit.wikimedia.org/r/791375

gerritbot added a comment.May 12 2022, 3:20 PM

Change 791383 merged by jenkins-bot:

[mediawiki/extensions/ArticlePlaceholder@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791383

gerritbot added a comment.May 12 2022, 3:45 PM

Change 791379 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791379

gerritbot added a comment.May 12 2022, 3:48 PM

Change 791378 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791378

Lucas_Werkmeister_WMDE mentioned this in rEWLC05e4ded61ec9: Update .phan/config.php for Wikibase stub changes.May 12 2022, 3:49 PM
gerritbot added a comment.May 12 2022, 4:04 PM

Change 791370 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791370

gerritbot added a comment.May 12 2022, 4:04 PM

Change 791380 merged by jenkins-bot:

[mediawiki/extensions/WikibaseManifest@master] Update .phan/config.php for Wikibase stub changes

https://gerrit.wikimedia.org/r/791380

Lucas_Werkmeister_WMDE mentioned this in rEWBN80309129f2d7: Update .phan/config.php for Wikibase stub changes.May 12 2022, 4:05 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.May 12 2022, 4:21 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 12 2022, 7:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits