| Sarai-WMDE | |
| May 12 2022, 5:27 PM |
| F35136136: Screenshot 2022-05-12 at 19.28.42.png | |
| May 12 2022, 5:29 PM |
| F35136008: Screenshot 2022-05-11 at 17.57.32.png | |
| May 12 2022, 5:27 PM |
When activated (on click), the custom footer added to the TypeaheadSearch menu does not display the same selected styles as the MenuItem component. In particular, the text color doesn't change to Accent50, like in the rest of the menu options.
We shouldn't make an exception but, instead, ensure that the menu footer's selected style matches that of MenuItems (designs available in this Figma frame).
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Menu, Typeahead: Apply MenuItem selected styles to Menu footer | design/codex | main | +27 -4 |
Change 805399 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):
[design/codex@main] Menu, Typeahead: Apply MenuItem selected styles to Menu footer
Change 805399 merged by jenkins-bot:
[design/codex@main] Menu, Typeahead: Apply MenuItem selected styles to Menu footer
Behavior and styles are correct in all last versions of Chrome, Firefox and Safari. I detected, though, that the footer's text keeps displaying the active blue color on mouseleave during mousedown. The correct behavior would be for the active styles to be fully removed in that case (see 803610 and T308170: MenuItems should lose highlighted and active states on mouseleave for reference). I'm not sure if this fix should be implemented as part of this same task, or if a separate ticket is needed. Would be happy to create it if so!