Search for tools when building list works differently than type ahead search for tools generally
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	bd808
	May 12 2022, 6:12 PM

Description

First reported by @Anthere

The backend search api used is the same for bot, but it seems that when used from the multi-select widget for adding tools to a list whitespace splitting is done differently.

An easy way to see the difference is by searching for "xtools edit" in both widgets:

From the general search in the production dataset, this will find both "XTools Edit Counter" (xtools-ec) and "XTools Edit Summaries" (xtools-editsummary) as the result for the backend https://toolhub.wikimedia.org/api/autocomplete/tools/?q=xtools+edit request.
From the list edit search, this will not find any results even though the same backend https://toolhub.wikimedia.org/api/autocomplete/tools/?q=xtools+edit request can be seen when watching XHR requests.

Details

	Subject	Repo	Branch	Lines +/-
	toolhub: Bump container version to 2022-06-30-170012-production	operations/deployment-charts	master	+1 -1
	ui: Add no-filter to v-combobox components	wikimedia/toolhub	main	+4 -0

Customize query in gerrit

Event Timeline

bd808 created this task.May 12 2022, 6:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2022, 6:12 PM

bd808 updated the task description. (Show Details)May 12 2022, 6:13 PM

bd808 added a subscriber: Anthere.

Raymond_Ndibe moved this task from Backlog to Groomed/Ready on the Toolhub board.May 23 2022, 7:27 PM

Slst2020 assigned this task to Raymond_Ndibe.May 23 2022, 7:27 PM

Slst2020 triaged this task as High priority.

Raymond_Ndibe added a project: User-Raymond_Ndibe.Jun 7 2022, 12:38 AM

Change 803565 had a related patch set uploaded (by Raymond Ndibe; author: Raymond Ndibe):

[wikimedia/toolhub@main] ui: Add no-filter to v-combobox components

https://gerrit.wikimedia.org/r/803565

gerritbot added a project: Patch-For-Review.Jun 7 2022, 4:29 PM

This was interesting to track down. It turns out this wasn't from the backend at all. I thought the v-combobox default filter algorithm has no effect on what is displayed. Not only does it has effect, it seems to behave differently for when the v-combobox component has a "multiple" props vs when it doesn't have the "multiple" props. Once figured out, the solution was to use the "no-filter" props. We don't need the filter since all filtering are already being done on the backend.

Raymond_Ndibe moved this task from Backlog to In Review on the User-Raymond_Ndibe board.Jun 7 2022, 5:01 PM

Thanks Raymond :)

Change 803565 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Add no-filter to v-combobox components

https://gerrit.wikimedia.org/r/803565

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2022, 9:30 AM

Raymond_Ndibe closed this task as Resolved.Jun 13 2022, 6:04 PM

Change 810079 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-06-30-170012-production

https://gerrit.wikimedia.org/r/810079

gerritbot added a project: Patch-For-Review.Jun 30 2022, 8:04 PM

Change 810079 merged by jenkins-bot: