Page MenuHomePhabricator
Create Task
Maniphest T308295

WindowManager does not clear iOS scroll prevention classes if teardown is called while a window is open
Closed, ResolvedPublic
Actions

Description

(reported by @mewoph in Slack)

  1. Open the mobile site, and set your user agent to iOS, e.g. by using the Chrome debugger mobile device toolbar
  2. Open a full page dialog:
mw.loader.using('oojs-ui').then( function () {
    OO.ui.alert('test',{size:'full'})
} );
  1. Before closing the dialog, destroy the window manager:
OO.ui.getWindowManager().destroy()

Observe that the page is now not scrollable.

The real-world test case is that when this patch is applied: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/763604, publishing change in VE on iOS results in the page being unscrollable, as the window manager is torn down while the save dialog is still open.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.44.1mediawiki/coremaster+1 K -822
WindowManager: Simplify teardownVisualEditor/VisualEditormaster+6 -0
Update VE core submodule to master (f07b7e2cf)mediawiki/extensions/VisualEditormaster+1 -1
WindowManager: Simplify teardownoojs/uimaster+0 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.May 12 2022, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 12 2022, 10:59 PM
gerritbot added a comment.May 12 2022, 11:00 PM

Change 791465 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] WindowManager: Simplify teardown

https://gerrit.wikimedia.org/r/791465

gerritbot added a project: Patch-For-Review.May 12 2022, 11:00 PM

Change 791466 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] WindowManager: Simplify teardown

https://gerrit.wikimedia.org/r/791466

gerritbot added a comment.May 13 2022, 12:27 AM

Change 791465 merged by jenkins-bot:

[oojs/ui@master] WindowManager: Simplify teardown

https://gerrit.wikimedia.org/r/791465

• ppelberg subscribed.May 13 2022, 2:39 AM
gerritbot added a comment.May 13 2022, 8:55 PM

Change 791466 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] WindowManager: Simplify teardown

https://gerrit.wikimedia.org/r/791466

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 9:30 PM
gerritbot added a comment.May 13 2022, 10:04 PM

Change 791698 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f07b7e2cf)

https://gerrit.wikimedia.org/r/791698

gerritbot added a project: Patch-For-Review.May 13 2022, 10:04 PM
gerritbot added a comment.May 13 2022, 10:24 PM

Change 791698 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f07b7e2cf)

https://gerrit.wikimedia.org/r/791698

Maintenance_bot removed a project: Patch-For-Review.May 13 2022, 10:30 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.May 13 2022, 10:46 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex added a project: Editing QA.
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 14 2022, 4:00 AM
Esanders claimed this task.May 16 2022, 5:11 PM
EAkinloose subscribed.May 16 2022, 5:45 PM

@matmarex, would it be correct to assume that this change should be visible on https://en.m.wikipedia.beta.wmflabs.org?
My observations:
Android works as expected: https://photos.app.goo.gl/CtoYKZ9ohSFaB2E2A
The page is not scrollable on iOS: https://photos.app.goo.gl/gpTMUQAzGM3NwCYv9

Let me know if I am not reproducing right..

EAkinloose moved this task from QA to Blocked / Needs More Work on the Editing-team (Kanban Board) board.May 16 2022, 5:46 PM
matmarex removed a project: Editing QA.May 17 2022, 5:19 PM

Sorry, the fix for this scenario isn't on https://en.m.wikipedia.beta.wmflabs.org yet, because the bug had to be fixed in the OOUI library, and we need to make a release and update MediaWiki to use it. This should happen probably next week.

We've made a separate fix for the "real-world test case" by manually backporting the fix in VisualEditor (in order to unblock T219420 without doing the OOUI release thing), but that only applies to dialogs in VisualEditor and not anything else.

Sorry, I didn't read the task description when moving this to QA. This is blocked for now, I'll update it when everything is ready.

gerritbot added a comment.Jul 13 2022, 1:35 PM

Change 813630 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

gerritbot added a project: Patch-For-Review.Jul 13 2022, 1:35 PM
gerritbot added a comment.Jul 13 2022, 3:23 PM

Change 813630 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.44.1

https://gerrit.wikimedia.org/r/813630

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2022, 3:31 PM
matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Jul 13 2022, 7:02 PM
matmarex added a project: Editing QA.
EAkinloose edited projects, added Verified; removed Editing QA.Jul 15 2022, 1:27 PM
In T308295#7931847, @EAkinloose wrote:

@matmarex, would it be correct to assume that this change should be visible on https://en.m.wikipedia.beta.wmflabs.org?
My observations:
Android works as expected: https://photos.app.goo.gl/CtoYKZ9ohSFaB2E2A
The page is not scrollable on iOS: https://photos.app.goo.gl/gpTMUQAzGM3NwCYv9

Let me know if I am not reproducing right..

All good now. See https://photos.app.goo.gl/rH6PXvg3ijFvUFsX8

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 15 2022, 1:27 PM
• ppelberg closed this task as Resolved.Jul 22 2022, 1:42 AM
matmarex edited projects, added OOUI (OOUI-0.44.1); removed OOUI.Aug 9 2022, 6:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL