Page MenuHomePhabricator

Use PrefixingStatsdDataFactoryProxy for suggested edits timings
Open, LowPublic

Description

Our Grafana dashboard is useful for spotting performance regressions. But it is not currently possible to look at data for specific wikis. We should use PrefixingStatsdDataFactoryProxy and then keep a short list (10 wikis?) to monitor performance by wiki. That would make it easier to spot issues like T308312: CacheDecorator does not work when AND filtering is enabled, where a wiki is seemingly performing worse than others, but that issue is lost in the aggregation of other wiki data.

Event Timeline

Tgr subscribed.

T240685: MediaWiki Prometheus support seems close enough to completion that I'd maybe just wait for that instead of creating a ton of new metrics.

Change #1101850 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] statslib(SuggestedEdits): migrate counter

https://gerrit.wikimedia.org/r/1101850

After discussing with @Michael we find that the change should be done for all charts in the Special:Homepage and Suggested Edits dashboard, the change can wait for when we build the new dashboard consuming Prometheus data.

Sgs triaged this task as Medium priority.Dec 17 2024, 3:47 PM
Sgs lowered the priority of this task from Medium to Low.