TypeError: missingLanguagesPanel.append is not a function / TypeError: Cannot read property 'indexOf' of undefined at getMissingFrequentLanguages
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

11726 errors in the last 7 days and 996 in the last 12hrs. (Over 1000 errors in last 12hrs is a train blocker https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Issues_that_hold_the_train). Please fix ASAP.

Error

mwversion: undefined
reqId: undefined
Find reqId in Logstash

normalized_message

TypeError: missingLanguagesPanel.append is not a function

exception.trace

at createMissingLanguagesPanel  <anonymous>:17:23
at <anonymous>:18:890
at Object.hooks. anonymous function).hooks.(anonymous function).fire (<anonymous>:377:636
at mw.loader.using.then.then.onOpen  <anonymous>:223:407
at <anonymous>:2:460

TypeError: Cannot read property 'indexOf' of undefined is presumably the same issue:

at getMissingFrequentLanguages  <anonymous>:17:792
at <anonymous>:18:755
at Object.hooks. anonymous function).hooks.(anonymous function).fire (<anonymous>:373:636
at mw.loader.using.then.then.e.onOpen  <anonymous>:219:407
at https://ja.m.wikipedia.org/w/load.php?lang=ja&modules=mobile.languages.structured&skin=minerva&version=amwya:2:460
tags
	
`

Impact

Notes

Details

Subject	Repo	Branch	Lines +/-
Limit the CX entrypoints to ES6 only browsers	mediawiki/extensions/ContentTranslation	master	+10 -0
Use appendChild instead of append to avoid browser compatibility issues	mediawiki/extensions/ContentTranslation	master	+4 -4
mffrequentlanguages entryopoint: Handle the case of undefined deviceLanguage	mediawiki/extensions/ContentTranslation	master	+14 -14

Customize query in gerrit

Event Timeline

Jdlrobson triaged this task as High priority.May 13 2022, 3:36 PM

Jdlrobson created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 13 2022, 3:36 PM

Jdlrobson renamed this task from TypeError: missingLanguagesPanel.append is not a function to TypeError: missingLanguagesPanel.append is not a function / TypeError: Cannot read property 'indexOf' of undefined at getMissingFrequentLanguages.May 13 2022, 3:41 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Language-Team.

Jdlrobson updated the task description. (Show Details)May 13 2022, 3:45 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMay 13 2022, 3:45 PM

This is on the cusp of being a train blocker so I am marking this as a blocker for 1.39.0-wmf.13 since 1.39.0-wmf.12 is only a few days away.

Jdlrobson added a parent task: T305219: 1.39.0-wmf.13 deployment blockers.May 13 2022, 3:46 PM

Nikerabbit edited projects, added Language-Team (Language-2022-April-June); removed Language-Team.May 13 2022, 3:47 PM

Nikerabbit added a subscriber: ngkountas.

Umherirrender added a project: JavaScript.May 15 2022, 6:03 PM

From the details of errors (require login), I see the errors are coming from old chrome browsers in old android version. Specifically from Chrome versions < 50.

Element.append is not available in Chrome<54.

TypeError: Cannot read property 'indexOf' of undefined is presumably the same issue:

at getMissingFrequentLanguages  <anonymous>:17:792
at <anonymous>:18:755
at Object.hooks. anonymous function).hooks.(anonymous function).fire (<anonymous>:373:636
at mw.loader.using.then.then.e.onOpen  <anonymous>:219:407
at https://ja.m.wikipedia.org/w/load.php?lang=ja&modules=mobile.languages.structured&skin=minerva&version=amwya:2:460
tags
	
`

This is happending because we are assuming languageSearcher.options.deviceLanguage is not null/undefined. But it can be undefined as per the documentation getDeviceLanguageOrParent method at MobileFrontend extension.

Change 791827 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] mffrequentlanguages entryopoint: Handle the case of undefined deviceLanguage

https://gerrit.wikimedia.org/r/791827

Change 791828 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Limit the CX entrypoints to ES6 only browsers

https://gerrit.wikimedia.org/r/791828

Change 791829 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Use appendChild instead of append to avoid browser compatibility issues

https://gerrit.wikimedia.org/r/791829

• santhosh claimed this task.May 16 2022, 5:09 AM

• santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.

Change 791827 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] mffrequentlanguages entryopoint: Handle the case of undefined deviceLanguage

https://gerrit.wikimedia.org/r/791827

Change 791829 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Use appendChild instead of append to avoid browser compatibility issues

https://gerrit.wikimedia.org/r/791829

Change 791828 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Limit the CX entrypoints to ES6 only browsers

https://gerrit.wikimedia.org/r/791828

Maintenance_bot removed a project: Patch-For-Review.May 16 2022, 11:30 AM

Thanks for the speedy handling of this one <3!

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 17 2022, 7:01 AM

Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-April-June) board.May 17 2022, 11:01 AM

thcipriani moved this task from Untriaged to May 2022 on the Wikimedia-production-error board.May 19 2022, 3:42 PM

Agusbou2015 subscribed.May 20 2022, 10:54 PM

@Jdlrobson it seems from the history that this isn't a train blocker. Can you confirm?

Jdlrobson removed a parent task: T305219: 1.39.0-wmf.13 deployment blockers.May 23 2022, 5:49 PM

ngkountas moved this task from Recheck after deployment to Needs QA on the Language-Team (Language-2022-April-June) board.May 30 2022, 12:25 PM

Unable to reproduce issue after fix in production. Tested in Chrome and Safari browsers

EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-April-June) board.Jun 1 2022, 4:03 AM

Pginer-WMF closed this task as Resolved.Jun 3 2022, 8:00 AM

TypeError: missingLanguagesPanel.append is not a function / TypeError: Cannot read property 'indexOf' of undefined at getMissingFrequentLanguagesClosed, ResolvedPublicPRODUCTION ERRORActions