Page MenuHomePhabricator

[Regression] Sticky header A/B test no longer usable
Closed, ResolvedPublic3 Estimated Story Points

Description

The changes in T307345 have caused a regression in how the sticky header A/B test works. Since in future we are considering an A/B test for new pilot wikis for sticky header we need to keep this working.

I should be able to disable the sticky header with the following configuration:

$wgVectorWebABTestEnrollment = [
	"name" => "vector.sticky_header",
	"enabled" => true,
	"buckets" => [
		"control" => [
			"samplingRate" => 0
		],
		"unsampled" => [
			"samplingRate" => 0
		],
		"stickyHeaderDisabled" => [
			"samplingRate" => 1
		],
		"stickyHeaderTreatment" => [
			"samplingRate" => 0
		]
	],
];
$wgVectorWebABTestEnrollment = [
	"name" => "vector.sticky_header",
	"enabled" => true,
	"buckets" => [
		"control" => [
			"samplingRate" => 0
		],
		"unsampled" => [
			"samplingRate" => 0
		],
		"stickyHeaderDisabled" => [
			"samplingRate" => 1
		],
		"stickyHeaderTreatment" => [
			"samplingRate" => 0
		]
	],
];

Event Timeline

Change 791676 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/skins/Vector@master] POC: fix sticky header A/B test to account for disabled buckets

https://gerrit.wikimedia.org/r/791676

ovasileva lowered the priority of this task from High to Medium.

Change 801824 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Explicitly destroy sticky header when it is not in use

https://gerrit.wikimedia.org/r/801824

Change 791676 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: fix sticky header A/B test to account for disabled buckets

Reason:

Thanks for this it was helpful! This is the solution I've gone with: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/801824

https://gerrit.wikimedia.org/r/791676

Change 801824 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Correctly hide the sticky header when it is not in use

https://gerrit.wikimedia.org/r/801824

Change 802217 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [Grid] Add TableOfContentsContainer

https://gerrit.wikimedia.org/r/802217

Edtadros subscribed.

This has already been validated in production here T310750#8069513