Page MenuHomePhabricator

Replace and remove deprecated `.transition()` Less mixin calls with unprefixed `transition` CSS property
Closed, ResolvedPublic

Description

Goal

Replace Less mixin calls for .transition(), which was deprecated in MediaWiki 1.37.

Criteria for Done

Replace with standard CSS transition:
https://codesearch.wmcloud.org/search/?q=%5C.transition%5C(&i=nope&files=(.*)%5C.(css%7Cless)%24&excludeFiles=&repos=
Alternatively:
https://codesearch-beta.wmcloud.org/deployed/?q=%5C.transition&files=&excludeFiles=&repos=

MediaWiki

  • MediaWiki core

Extensions

Note, #GettingStarted is ignored, as it's undeployed.

Skins

Volunteer repos [not essential for resolving]

Remove mixin

  • Remove from MW core's mediawiki.mixins.less file and make note in release notes

Details

SubjectRepoBranchLines +/-
mediawiki/coremaster+4 -28
mediawiki/skins/Materialmaster+8 -12
mediawiki/extensions/GettingStartedmaster+3 -4
mediawiki/skins/Miragemaster+2 -3
mediawiki/extensions/MachineVisionmaster+15 -15
mediawiki/skins/Refreshedmaster+3 -3
mediawiki/skins/Refreshedmaster+3 -3
mediawiki/extensions/Popupsmaster+3 -4
mediawiki/extensions/Flowmaster+2 -2
mediawiki/extensions/Echomaster+1 -27
mediawiki/extensions/Kartographermaster+2 -2
mediawiki/extensions/WikiEditormaster+9 -9
mediawiki/extensions/GuidedTourmaster+1 -1
mediawiki/extensions/ContentTranslationmaster+15 -17
mediawiki/extensions/MediaSearchmaster+12 -16
mediawiki/extensions/WikidataPageBannermaster+4 -10
mediawiki/extensions/CheckUsermaster+2 -3
mediawiki/extensions/UniversalLanguageSelectormaster+1 -1
mediawiki/skins/MinervaNeuemaster+35 -50
mediawiki/extensions/MobileFrontendmaster+12 -37
mediawiki/coremaster+18 -20
mediawiki/coremaster+7 -39
mediawiki/skins/Vectormaster+16 -15
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

@TySambar: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

TySambar subscribed.

@Aklapper thanks for reaching out! I picked up this task as a good first task since it's just a find and replace to help me figure out permissions and such. Got a code review on my change set today -- my fault for not assigning any reviewers. I'm un-assigning this task now so that other newbies can use it.

Change 883640 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/WikidataPageBanner@master] style: Replaced deprecated mixins prefixes

https://gerrit.wikimedia.org/r/883640

Change 883643 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/UniversalLanguageSelector@master] style: Replace deprecated prefixed mixins with unprefixed CSS property

https://gerrit.wikimedia.org/r/883643

Change 883643 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] style: Replace deprecated prefixed mixins with unprefixed CSS property

https://gerrit.wikimedia.org/r/883643

Change 884389 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/WikiEditor@master] Styles: Replaces deprecated mixins prefixes with unprefixed CSS property

https://gerrit.wikimedia.org/r/884389

Change 884391 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/CheckUser@master] styles: Replace deprecated mixins prefix styles

https://gerrit.wikimedia.org/r/884391

Change 884401 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/GuidedTour@master] style: replaced deprecated mixins prefixe

https://gerrit.wikimedia.org/r/884401

Change 884404 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/MediaSearch@master] style: replaced deprecated mixins preffixes with CSS unprefixed property

https://gerrit.wikimedia.org/r/884404

Change 883577 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/ContentTranslation@master] Styles: Replaced deprecated mixins prefixes ( .transition(), .transform(), .background-image() )

https://gerrit.wikimedia.org/r/883577

Change 884391 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] styles: Replace deprecated mixins prefix styles

https://gerrit.wikimedia.org/r/884391

Change 883640 merged by jenkins-bot:

[mediawiki/extensions/WikidataPageBanner@master] styles: Replaced deprecated mixins prefixes

https://gerrit.wikimedia.org/r/883640

Volker_E updated the task description. (Show Details)

Change 884404 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/884404

Volker_E updated the task description. (Show Details)

Change 883577 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] styles: Replace deprecated Less mixins

https://gerrit.wikimedia.org/r/883577

Change 884401 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] styles: Replace deprecated Less mixins

https://gerrit.wikimedia.org/r/884401

Change 884389 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Styles: Replaces deprecated mixins prefixes with unprefixed CSS property

https://gerrit.wikimedia.org/r/884389

Volker_E updated the task description. (Show Details)

Change 886164 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Flow@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/886164

Change 886166 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Echo@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/886166

Change 886169 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/Kartographer@master] styles: Replaces deprecated mixin with unprefixed CSS property

https://gerrit.wikimedia.org/r/886169

Please I'm having difficulty locating Page-Preview, Maps, and StructuredDiscussion from Gerrit's list of Repos.
Can someone points me to the links of these repos, or if they have been, what is the current name

Change 886166 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/886166

Change 886169 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] styles: Replaces deprecated mixin with unprefixed CSS property

https://gerrit.wikimedia.org/r/886169

Change 886164 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] styles: Replace deprecated Less mixin with CSS unprefixed property

https://gerrit.wikimedia.org/r/886164

Please I'm having difficulty locating Page-Preview, Maps, and StructuredDiscussion from Gerrit's list of Repos.
Can someone points me to the links of these repos, or if they have been, what is the current name

Hi @Collins, no problem it can be confusing at times:

  • Page previews is called Popups in its former name

I've already fixed Maps (Kartographer) and StructuredDiscussions (Echo) to streamline this.

Please I'm having difficulty locating Page-Preview, Maps, and StructuredDiscussion from Gerrit's list of Repos.
Can someone points me to the links of these repos, or if they have been, what is the current name

Hi @Collins, no problem it can be confusing at times:

  • Page previews is called Popups in its former name

I've already fixed Maps (Kartographer) and StructuredDiscussions (Echo) to streamline this.

Okay, thanks for the pointer.
Will have a look.

Change 886395 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Popups@master] Replaced deprecated less mixin calls with unprefixed CSS property.

https://gerrit.wikimedia.org/r/886395

Change 886395 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] styles: Replace deprecated Less mixin calls with unprefixed CSS property

https://gerrit.wikimedia.org/r/886395

Volker_E updated the task description. (Show Details)

Change 886432 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Refreshed@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/886432

Change 887770 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/skins/Refreshed@master] Style: Replaced deprecated mixins with standard CSS property

https://gerrit.wikimedia.org/r/887770

Change 887770 merged by jenkins-bot:

[mediawiki/skins/Refreshed@master] styles: Replaced deprecated mixins with standard CSS property

https://gerrit.wikimedia.org/r/887770

Change 886432 abandoned by VolkerE:

[mediawiki/skins/Refreshed@master] styles: Replace deprecated Less mixins with CSS unprefixed property

Reason:

another patch by volunteer took priority

https://gerrit.wikimedia.org/r/886432

@Collins I've already provided a patch for Refreshed above, have still merged yours. But please make sure that you double-check what is already on the task in order to not duplicate work in future.

Change 887868 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/MachineVision@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/887868

Change 887868 merged by jenkins-bot:

[mediawiki/extensions/MachineVision@master] styles: Replace deprecated Less mixins with CSS unprefixed property

https://gerrit.wikimedia.org/r/887868

Volker_E renamed this task from Replace deprecated `.transition()` Less mixin calls with unprefixed `transition` CSS property to Replace and remove deprecated `.transition()` Less mixin calls with unprefixed `transition` CSS property.Feb 9 2023, 1:46 PM
Volker_E updated the task description. (Show Details)

Change 889132 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/skins/Material@master] Style: Replaced deprecated mixins with standard CSS property

https://gerrit.wikimedia.org/r/889132

Change 889137 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/skins/Mirage@master] Style: replaced deprecated mixin with standard CSS property

https://gerrit.wikimedia.org/r/889137

Change 889137 merged by jenkins-bot:

[mediawiki/skins/Mirage@master] Style: replaced deprecated mixin with standard CSS property

https://gerrit.wikimedia.org/r/889137

Change 889144 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/GettingStarted@master] Style: Replaced deprecated mixin with standard CSS property

https://gerrit.wikimedia.org/r/889144

Change 889144 merged by jenkins-bot:

[mediawiki/extensions/GettingStarted@master] Style: Replaced deprecated mixin with standard CSS property

https://gerrit.wikimedia.org/r/889144

Hi, tried investigating where I can find the projects listed under the Volunteer section on the task description and I could not find anything.
Please any pointers, if it's not of high priority then it can be left out for now.

Change 889132 merged by jenkins-bot:

[mediawiki/skins/Material@master] Style: Replaced deprecated mixins with standard CSS property

https://gerrit.wikimedia.org/r/889132

Change 917965 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.mixins: Remove deprecated Less mixins as of 1.37.0

https://gerrit.wikimedia.org/r/917965

Change 917965 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.mixins: Remove deprecated Less mixins as of 1.37.0

https://gerrit.wikimedia.org/r/917965

Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: Collins.