Page MenuHomePhabricator

Avoid direct link to edit non-existing talk pages in Minerva
Open, Needs TriagePublic

Description

If the talk page doesn't exist, Minerva redirects automatically to an edit links. For instance, https://m.wikidata.org/w/index.php?title=Talk:Q21510382 redirects to https://m.wikidata.org/w/index.php?title=Talk:Q21510382&redlink=1#/editor/all.

This is a bad user experience since it hides the talkpage header. I suggest to remove this feature.

Event Timeline

Tacsipacsi added a project: DiscussionTools.
Tacsipacsi subscribed.

Clicking on that link doesn’t redirect me anywhere. Clicking on the Talk page tab on the item page does (as the link contains action=edit), but it won’t once the New Discussion Tool is introduced on mobile.

Thanks for your answer. Do you know if we could some JS script in the user page (https://m.wikidata.org/wiki/User:PAC2/minerva.js) to avoid this behaviour? Do you have more details about the calendar of the discussion tool?

$(function () {
	var talk = document.querySelector('.minerva__tab[rel="discussion"]');
	if (talk) {
		talk.href = talk.href.replace('&action=edit&redlink=1', '');
	}
}());

may work, but I didn’t test it for edge cases.

The mobile Reply Tool and New Topic Tool have just been enabled on a few Wikipedias (the so-called “partner wikis”) on last Wednesday (T282638), so I’d expect its deployment to Wikidata to be in no less than a few months, maybe even more.

Thanks. Your script seems perfect.

Esanders claimed this task.
Esanders subscribed.

DT mobile is deployed everywhere.

Tacsipacsi removed Esanders as the assignee of this task.

DT mobile is deployed everywhere.

No. For example, it’s not deployed in my private wiki. It’s probably not deployed in many other third-party wikis either. It’s one thing if you decline it, but it should not be considered resolved unless DiscussionTools becomes a hard dependency of MobileFrontend (which I very much hope won’t happen, since not all wikis need perfect discussion tools, and some may want to rather have as few extensions as possible).

The report is about Minerva without DiscussionTools. Where could it be fixed if not in the Minerva codebase?

Jdlrobson claimed this task.
Jdlrobson subscribed.

Reading through the history please open a new ticket if you want this looked at. Your 3rd party bug ia very different.

Tacsipacsi removed Jdlrobson as the assignee of this task.
Tacsipacsi removed a project: DiscussionTools.

Why would it be different? The bug is, and has always been, that Minerva without DiscussionTools doesn’t show the talk page header when the talk page tab is clicked. (I indeed connected this task to DiscussionTools back in 2022, but that was inappropriate in hindsight, because not everyone uses DiscussionTools.) This has not been fixed, so this task should not be closed as resolved. It’s insignificant whether this happens on first-party or third-party wikis. (By the way, it still happens on first-party wikis as well, if one opts out of DiscussionTools on redlinked talk pages.)

I could open a new task with the exact same data, but what purpose would that serve? The task number would be a bit higher, that’s all.