List of steps to reproduce:
- View a patch (e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/776355)
- View a file diff
- Observe colour scheme being red/green
- Go back and compare a patchset not against base (compare 1/6; https://gerrit.wikimedia.org/r/c/mediawiki/core/+/776355/1..6)
- View a file diff
- Observe colour scheme being yellow/blue
What happens?:
If the comparison isn't against base, the colour scheme changes.
Note that this isn't always the case. Some comparisons are red/green, others aren't.
In certain cases, all four colours are used. (includes/resourceloader/ResourceLoader.php in the example linked above)
What should have happened instead?:
The colour scheme should be consistent. I don't care which one it is (having a slight preference for red/green because the contrast is better) as long as it is consistent.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Whatever version of Gerrit we're running (3.4.4, but was happening earlier).
Also occurs when using incognito/not-logged in, so it can't be my particular preferences.
Related: T232893: Gerrit red-green diff make the code hard to read (impossible for color-blind users)