Page MenuHomePhabricator
Create Task
Maniphest T308406

RemexHtml should support PHP 8.1
Closed, ResolvedPublicBUG REPORT
Actions

Description

Testing master with 8.1 and deprecations reporting on, phpunit does not even get started before complaining about a bunch of return types in RemexHtml.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Specify return types to make PHP 8.1 happymediawiki/libs/RemexHtmlmaster+17 -17
Make this work with 8.1mediawiki/libs/RemexHtmlmaster+18 -8
Skip PHP 8.1 on RemexHtmlintegration/configmaster+2 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT396296 Upgrade symfony/* to PHP 8.1 versions
 ResolvedReedyT373753 Drop symfony/polyfill-php 73-81 from mediawiki-vendor
 StalledNoneT255792 Quibble runs core:unit tests twice!
 OpenNoneT376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
 OpenNoneT379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
 ResolvedReedyT378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
 OpenNoneT358666 Drop PHP 8.1 support from MediaWiki
 OpenKrinkleT360995 Migrate Wikimedia production from PHP 8.1 to PHP 8.3
 ResolvedJdforrester-WMFT353362 Make PHP 8.3 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
 ResolvedJdforrester-WMFT352085 Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries)
 ResolvedJdforrester-WMFT360560 Make PHP 8.2 voting on development branch of Wikibase
 ResolvedLucas_Werkmeister_WMDET324202 Remove use of utf8_encode and utf8_decode in Wikibase
 ResolvedNoneT353161 [CLIENT] Creation of dynamic property MediaWiki\Title\Title::$wikibasePushedDeleteToRepo is deprecated
 ResolvedJdforrester-WMFT360709 Make PHP 8.2 voting on development (master) branch of Math extension
 ResolvedDaimonaT381728 Use PHP 8.3 in MediaWiki-Docker
 ResolvedJdforrester-WMFT398491 Move CI images to WMF PHP 8.3 packages
 OpenNoneT401255 Switch PHP 8.3 image of MediaWiki-Docker from Sury to WMF
 ResolvedScott_FrenchT401254 Upgrade mw-debug/next to PHP 8.3
 ResolvedScott_FrenchT401252 Configure title-case consistency mapping for PHP 8.1 -> 8.3 transition
 ResolvedScott_FrenchT399884 Configure production MediaWiki image builds for PHP 8.3
 OpencscottT401855 ☂ PHP 8.3 issues found during WMF rollout
 ResolvedScott_FrenchT402424 PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /srv/monitoring/lib.php on line 99
 DuplicatePRODUCTION ERRORNoneT403514 Expectation (readQueryRows <= 10000) by MediaWiki\Actions\ActionEntryPoint::execute not met (actual: 12860)
 ResolvedPRODUCTION ERRORMichaelT407403 Error: Invalid serialization data for DatePeriod object
 OpenPRODUCTION ERRORNoneT408852 PHP Deprecated: DateTime::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated
 OpenMichaelT401005 Investigate Production Errors from ComputedUserImpactLookup::getPageViewData
 DuplicatePRODUCTION ERRORNoneT409248 PHP Warning: Trying to access array offset on null
 ResolvedTgrT402597 Exploratory testing on PHP 8.3 for MediaWiki Platform Team components
 ResolvedNoneT402804 Exploratory testing on PHP 8.3 for MediaWiki authentication stack
 ResolvedDAlangi_WMFT403484 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Login
 ResolvedTgrT403485 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Central session
 ResolvedDAlangi_WMFT403486 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: Signup
 ResolvedTgrT403487 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: OAuth
 ResolvedTgrT403488 Exploratory testing on PHP 8.3 for MediaWiki authentication stack: 2FA
 ResolvedAtienoT402809 Exploratory testing on PHP 8.3 for MediaWiki Interfaces Team components
 OpenNoneT402810 Exploratory testing on PHP 8.3 for Content Transform Team components
 ResolvedbrouberolT403110 Prepare dumps-on-k8s (mediawiki-dumps-legacy) for migration to PHP 8.3
 ResolvedScott_FrenchT403655 Configure mw-next-routing for the PHP 8.3 migration
 ResolvedScott_FrenchT403657 Configure the WikimediaEvents extension for the PHP 8.3 migration
 ResolvedScott_FrenchT403284 Migrate production Shellbox services to PHP 8.3
 ResolvedScott_FrenchT403283 Prepare PHP 8.3 service images for Shellbox
 ResolvedScott_FrenchT398246 Prepare PHP 8.3 production images
 ResolvedScott_FrenchT398245 Prepare WMF PHP 8.3 packages for bullseye
 ResolvedKrinkleT400109 Ensure MediaWiki-Core-Profiler works with php-xhprof 2.x (PHP 8.3)
 ResolvedKrinkleT401152 Switch wmf-config/Profiler from Tideways to XHProf
 ResolvedScott_FrenchT403772 Migrate parsoidtest1001 to PHP 8.3
 ResolvedKrinkleT405031 lcobucci/clock needs upgrading for PHP 8.3
 ResolvedTgrT363639 web-auth/webauthn-lib must be upgraded to 4+ for PHP 8.2+ support
 ResolvedScott_FrenchT405955 MediaWiki on PHP 8.3 production workload migration
 Resolved• jnucheT411277 Patchdemo wiki creation fails due to PHP 8.1 not supported by MW
 ResolvedJdforrester-WMFT411372 wikilambda-catalyst-end-to-end broken due to new version of composer after PHP 8.1 -> 8.3 migration
 ResolvedBUG REPORT• bd808T411235 Beta cluster scap using php8.1 container; php8.2 is now required
 ResolvedReedyT380185 Prepare for newer geoip2/geoip2 library
 ResolvedReedyT338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
 Resolvedseanleong-WMDET379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
 StalledNoneT334726 Use return type `never` in Wikibase
 OpenNoneT328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
 ResolvedLucas_Werkmeister_WMDET328741 Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
 ResolvedDaimonaT342110 Upgrade to PHPUnit 9.6
 ResolvedDaimonaT342259 Move MediaWikiIntegrationTestCase setup and teardown away from run()
 ResolvedDaimonaT342301 Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
 OpenNoneT332865 PHPUnit data providers should be simple static functions that return plain data
 ResolvedUmherirrenderT337130 Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension)
 OpenNoneT337135 Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
 ResolvedUmherirrenderT337144 Make PHPUnit dataProvider static in AbuseFilter tests
 ResolvedUmherirrenderT337155 Make PHPUnit dataProvider static in ReadingLists tests
 Resolved• mszaboT337156 Make PHPUnit dataProvider static in IPInfo tests
 ResolvedtstarlingT337157 Make PHPUnit dataProvider static in LoginNotify tests
 ResolvedUmherirrenderT337158 Make PHPUnit dataProvider static in Flow tests
 ResolvedDreamy_JazzT337159 Make PHPUnit dataProvider static in CheckUser tests
 ResolvedDreamy_JazzT346044 Remove CheckUserUnionQueryBuilder
 ResolvedPhysikerweltT337160 Make PHPUnit dataProvider static in Math tests
 ResolvedTgrT337161 Make PHPUnit dataProvider static in OAuth tests
 ResolvedUmherirrenderT337162 Make PHPUnit dataProvider static in ProofreadPage tests
 ResolvedUmherirrenderT337163 Make PHPUnit dataProvider static in CirrusSearch tests
 ResolvedNoneT337164 Make PHPUnit dataProvider static in FileImporter tests
 ResolvedUmherirrenderT337165 Make PHPUnit dataProvider static in GrowthExperiments tests
 ResolvedNoneT337166 Make PHPUnit dataProvider static in CampaignEvents tests
 ResolvedNoneT371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
 ResolvedkarapayneWMDET337154 Make PHPUnit dataProvider static in Wikibase tests
 ResolvedAudreyPenven_WMDET380604 Make provideLuaData static
 ResolvedAudreyPenven_WMDET380605 Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
 ResolvedLucas_Werkmeister_WMDET337153 Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
 ResolvedLucas_Werkmeister_WMDET337151 Make PHPUnit dataProvider static in WikibaseLexeme tests
 ResolvedUmherirrenderT337152 Make PHPUnit dataProvider static in WikibaseMediaInfo tests
 ResolvedthiemowmdeT337150 Make PHPUnit dataProvider static in Wikidata.org tests
 ResolvedLucas_Werkmeister_WMDET337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
 ResolvedUmherirrenderT393065 Make PHPUnit dataProvider on ExtensionJsonTestBase static
 ResolvedUmherirrenderT393079 Make PHPUnit dataProvider static in CommunityConfiguration tests
 ResolvedUmherirrenderT393080 Make PHPUnit dataProvider static in AutoModerator tests
 ResolvedUmherirrenderT393081 Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static
 ResolvedUmherirrenderT393082 Make PHPUnit dataProvider on OutputTransformStageTestBase static
 ResolvedUmherirrenderT393084 Make PHPUnit dataProvider on TypeDefTestCaseTrait static
 Resolved• mszaboT393115 Make PHPUnit dataProvider on PasswordTestCase static
 ResolvedxSavitarT393122 Make PHPUnit dataProvider on BundleSizeTestBase static
 ResolvedUmherirrenderT393132 Make PHPUnit dataProvider on RevisionRecordTests static
 ResolvedUmherirrenderT393207 Make PHPUnit dataProvider on ExtensionServicesTestBase static
 ResolvedUmherirrenderT393219 Make PHPUnit dataProvider on RestStructureTest static
 OpenNoneT410731 Make production extensions PHPUnit tests data providers real providers (and use static methods)
 OpenNoneT345481 Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
 OpenNoneT358394 Stop using PHPUnit's TestSuite in Scribunto
 OpenDannyS712T363064 MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
 ResolvedUmherirrenderT363641 IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 Resolved• larissagauliaT363650 Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
 ResolvedUmherirrenderT362858 equivset: Expecting E_ERROR and E_USER_ERROR is deprecated
 ResolvedJdforrester-WMFT395743 Use of package ockcyp/covers-validator in libaries is not compatible with PHPUnit 10
 ResolvedJdforrester-WMFT319055 Upgrade to psr/container 2.x
 ResolvedJdforrester-WMFT328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki
 ResolvedKrinkleT319432 Migrate WMF production from PHP 7.4 to PHP 8.1
 ResolvedJdforrester-WMFT316078 Make PHP 8.1 voting on development (master) branch of MW ecosystem (core, extensions, skins, libraries)
 ResolvedJdforrester-WMFT319065 All Wikimedia production extensions and skins must support PHP 8.1
 ResolvedNoneT307506 Address PHP 8.1 job failures on various PHP libs
 ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
 ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
 ResolvedtstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1

Event Timeline

MarkAHershberger created this task.May 15 2022, 5:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2022, 5:30 PM
MarkAHershberger moved this task from Blocker to Process on the MW-1.38-release board.May 15 2022, 5:31 PM
MarkAHershberger moved this task from Process to Not a blocker on the MW-1.38-release board.
gerritbot added a comment.May 15 2022, 5:41 PM

Change 791796 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/libs/RemexHtml@master] Make this work with 8.1

https://gerrit.wikimedia.org/r/791796

gerritbot added a project: Patch-For-Review.May 15 2022, 5:41 PM
Reedy subscribed.May 18 2022, 6:19 PM

In theory, it potentially should in all supported release branches...

Reedy renamed this task from RemexHtml should support php 8.1 for REL1_38 to RemexHtml should support PHP 8.1.May 21 2022, 8:13 AM
Reedy added projects: PHP 8.1 support, MW-1.35-release, MW-1.37-release.
Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.May 21 2022, 8:17 AM
Reedy moved this task from Blocker to Not a blocker on the MW-1.37-release board.
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.May 21 2022, 8:20 AM
Reedy added a comment.Jun 26 2022, 8:23 PM

See also https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/786306

Reedy added a subtask: T307630: mediawiki/libs/RemexHtml phan issues under 8.1.Jun 26 2022, 8:24 PM
Reedy mentioned this in T311366: MobileFrontend PHP 8.1 support.Jun 27 2022, 11:53 AM
Reedy triaged this task as High priority.Jun 27 2022, 6:56 PM

Marking this as high as Ubuntu 22.04 ships with PHP 8.1... And it'd be nice to have this buried dependancy not spam all of the logs ;D

T307630: mediawiki/libs/RemexHtml phan issues under 8.1 will probably need fixing first/at the same time, unfortunately.

gerritbot added a comment.Jun 27 2022, 7:23 PM

Change 809000 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Skip PHP 8.1 on RemexHtml

https://gerrit.wikimedia.org/r/809000

gerritbot added a comment.Jun 27 2022, 7:27 PM

Change 809000 merged by jenkins-bot:

[integration/config@master] Skip PHP 8.1 on RemexHtml

https://gerrit.wikimedia.org/r/809000

Stashbot added a comment.Jun 27 2022, 7:28 PM

Mentioned in SAL (#wikimedia-releng) [2022-06-27T19:28:03Z] <Reedy> Reloading Zuul to deploy https://phabricator.wikimedia.org/T308406

gerritbot added a comment.Jun 27 2022, 7:30 PM

Change 786306 had a related patch set uploaded (by Reedy; author: Simetrical):

[mediawiki/libs/RemexHtml@master] Specify return types to make PHP 8.1 happy

https://gerrit.wikimedia.org/r/786306

gerritbot added a comment.Jun 27 2022, 7:31 PM

Change 791796 abandoned by Reedy:

[mediawiki/libs/RemexHtml@master] Make this work with 8.1

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/786306

https://gerrit.wikimedia.org/r/791796

gerritbot added a comment.Jun 27 2022, 7:31 PM

Change 786306 merged by jenkins-bot:

[mediawiki/libs/RemexHtml@master] Specify return types to make PHP 8.1 happy

https://gerrit.wikimedia.org/r/786306

Reedy added a parent task: T311450: Re-enable PHP 8.1 CI on RemexHTML.Jun 27 2022, 7:33 PM
Reedy removed a project: Patch-For-Review.Jun 28 2022, 11:56 PM
Reedy moved this task from Wikimedia production to Other on the PHP 8.1 support board.Jun 30 2022, 12:30 AM
Jdforrester-WMF moved this task from Other to Wikimedia production on the PHP 8.1 support board.Oct 14 2022, 2:16 PM
Jdforrester-WMF closed this task as Resolved.Oct 31 2022, 3:44 PM
Jdforrester-WMF closed subtask T307630: mediawiki/libs/RemexHtml phan issues under 8.1 as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits