Page MenuHomePhabricator
Create Task
Maniphest T308406

RemexHtml should support PHP 8.1
Closed, ResolvedPublicBUG REPORT
Actions

Description

Testing master with 8.1 and deprecations reporting on, phpunit does not even get started before complaining about a bunch of return types in RemexHtml.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Specify return types to make PHP 8.1 happySimetricalmediawiki/libs/RemexHtmlmaster+17 -17
Make this work with 8.1MarkAHershbergermediawiki/libs/RemexHtmlmaster+18 -8
Skip PHP 8.1 on RemexHtmlReedyintegration/configmaster+2 -1
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedJdforrester-WMFT311450 Re-enable PHP 8.1 CI on RemexHTML
ResolvedBUG REPORTNoneT308406 RemexHtml should support PHP 8.1
ResolvedtstarlingT307630 mediawiki/libs/RemexHtml phan issues under 8.1
· · ·

Event Timeline

MarkAHershberger created this task.May 15 2022, 5:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2022, 5:30 PM
MarkAHershberger moved this task from Blocker to Process on the MW-1.38-release board.May 15 2022, 5:31 PM
MarkAHershberger moved this task from Process to Not a blocker on the MW-1.38-release board.
gerritbot added a comment.May 15 2022, 5:41 PM

Change 791796 had a related patch set uploaded (by MarkAHershberger; author: MarkAHershberger):

[mediawiki/libs/RemexHtml@master] Make this work with 8.1

https://gerrit.wikimedia.org/r/791796

gerritbot added a project: Patch-For-Review.May 15 2022, 5:41 PM
Reedy subscribed.May 18 2022, 6:19 PM

In theory, it potentially should in all supported release branches...

Reedy renamed this task from RemexHtml should support php 8.1 for REL1_38 to RemexHtml should support PHP 8.1.May 21 2022, 8:13 AM
Reedy added projects: PHP 8.1 support, MW-1.35-release, MW-1.37-release.
Reedy moved this task from Blocker to Not a blocker on the MW-1.35-release board.May 21 2022, 8:17 AM
Reedy moved this task from Blocker to Not a blocker on the MW-1.37-release board.
Reedy moved this task from Backlog to Wikimedia production on the PHP 8.1 support board.May 21 2022, 8:20 AM
Reedy added a comment.Jun 26 2022, 8:23 PM

See also https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/786306

Reedy added a subtask: T307630: mediawiki/libs/RemexHtml phan issues under 8.1.Jun 26 2022, 8:24 PM
Reedy mentioned this in T311366: MobileFrontend PHP 8.1 support.Jun 27 2022, 11:53 AM
Reedy triaged this task as High priority.Jun 27 2022, 6:56 PM

Marking this as high as Ubuntu 22.04 ships with PHP 8.1... And it'd be nice to have this buried dependancy not spam all of the logs ;D

T307630: mediawiki/libs/RemexHtml phan issues under 8.1 will probably need fixing first/at the same time, unfortunately.

gerritbot added a comment.Jun 27 2022, 7:23 PM

Change 809000 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Skip PHP 8.1 on RemexHtml

https://gerrit.wikimedia.org/r/809000

gerritbot added a comment.Jun 27 2022, 7:27 PM

Change 809000 merged by jenkins-bot:

[integration/config@master] Skip PHP 8.1 on RemexHtml

https://gerrit.wikimedia.org/r/809000

Stashbot added a comment.Jun 27 2022, 7:28 PM

Mentioned in SAL (#wikimedia-releng) [2022-06-27T19:28:03Z] <Reedy> Reloading Zuul to deploy https://phabricator.wikimedia.org/T308406

gerritbot added a comment.Jun 27 2022, 7:30 PM

Change 786306 had a related patch set uploaded (by Reedy; author: Simetrical):

[mediawiki/libs/RemexHtml@master] Specify return types to make PHP 8.1 happy

https://gerrit.wikimedia.org/r/786306

gerritbot added a comment.Jun 27 2022, 7:31 PM

Change 791796 abandoned by Reedy:

[mediawiki/libs/RemexHtml@master] Make this work with 8.1

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/786306

https://gerrit.wikimedia.org/r/791796

gerritbot added a comment.Jun 27 2022, 7:31 PM

Change 786306 merged by jenkins-bot:

[mediawiki/libs/RemexHtml@master] Specify return types to make PHP 8.1 happy

https://gerrit.wikimedia.org/r/786306

Reedy added a parent task: T311450: Re-enable PHP 8.1 CI on RemexHTML.Jun 27 2022, 7:33 PM
Reedy removed a project: Patch-For-Review.Jun 28 2022, 11:56 PM
Reedy moved this task from Wikimedia production to Other on the PHP 8.1 support board.Jun 30 2022, 12:30 AM
Jdforrester-WMF moved this task from Other to Wikimedia production on the PHP 8.1 support board.Oct 14 2022, 2:16 PM
Jdforrester-WMF closed this task as Resolved.Oct 31 2022, 3:44 PM
Jdforrester-WMF closed subtask T307630: mediawiki/libs/RemexHtml phan issues under 8.1 as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits