Page MenuHomePhabricator
Create Task
Maniphest T308437

🟫️ Change `GetItem` use case to return an `ItemData` object in the response
Closed, ResolvedPublic
Actions

Description

  • create ItemData class
  • instantiate ItemData in the use case (to be moved into the retriever as part of T307915)
  • create ItemDataSerializer
  • serialize in presenter

Details

SubjectRepoBranchLines +/-
REST: Avoid using EmptyArrayToObjectConvertermediawiki/extensions/Wikibasemaster+37 -39
REST: Serialize in presenter for GetItemmediawiki/extensions/Wikibasemaster+558 -430
Extract SiteLinkListSerializer from ItemSerializermediawiki/extensions/Wikibasemaster+82 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ollie.Shotton_WMDE renamed this task from Change `GetItem` use case to return an `ItemData` object in the response to 🟫️ Change `GetItem` use case to return an `ItemData` object in the response.May 16 2022, 1:17 PM
Ollie.Shotton_WMDE created this task.
Ollie.Shotton_WMDE mentioned this in T308435: ⬛️ Create an `ItemDataRetriever` interface.
Ollie.Shotton_WMDE removed a project: MW-1.39-notes (1.39.0-wmf.12; 2022-05-16).May 16 2022, 1:34 PM
Jakob_WMDE claimed this task.May 17 2022, 1:48 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 6) board.
gerritbot added a comment.May 17 2022, 3:12 PM

Change 792631 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add ItemData and builder

https://gerrit.wikimedia.org/r/792631

gerritbot added a project: Patch-For-Review.May 17 2022, 3:12 PM
gerritbot added a comment.May 18 2022, 10:27 AM

Change 793017 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Extract SiteLinkListSerializer from ItemSerializer

https://gerrit.wikimedia.org/r/793017

gerritbot added a comment.May 18 2022, 11:29 AM

Change 793017 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Extract SiteLinkListSerializer from ItemSerializer

https://gerrit.wikimedia.org/r/793017

Jakob_WMDE removed Jakob_WMDE as the assignee of this task.May 18 2022, 2:54 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 6) board.
gerritbot added a comment.May 18 2022, 4:10 PM

Change 793088 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Avoid using EmptyArrayToObjectConverter

https://gerrit.wikimedia.org/r/793088

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 18 2022, 5:00 PM
gerritbot added a comment.May 19 2022, 8:08 AM

Change 792631 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Serialize in presenter for GetItem

https://gerrit.wikimedia.org/r/792631

gerritbot added a comment.May 19 2022, 8:08 AM

Change 793088 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Avoid using EmptyArrayToObjectConverter

https://gerrit.wikimedia.org/r/793088

Maintenance_bot removed a project: Patch-For-Review.May 19 2022, 8:30 AM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 6) board.May 20 2022, 3:30 PM
Silvan_WMDE subscribed.

✔ post-merge review

WMDE-leszek closed this task as Resolved.May 25 2022, 12:43 PM
WMDE-leszek claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL