Page MenuHomePhabricator

openstack-browser stopped showing puppet classes in use
Closed, ResolvedPublic

Description

At https://openstack-browser.toolforge.org/puppetclass/ there is no more output showing which puppet classes are used where in cloud.

Until recently it showed the puppet classes in use and I regularly used it to check whether a certain class is still in use (and not just not in use in production before deleting it, for example).

Bryan said "looks to me like the puppet-enc backend is now requiring auth even for browsing and that is making all the anon queries done by the tool fail."

Event Timeline

I wasn't sure what the right tag is here. cloud-services looked right but then I noticed that doesn't make a ticket show up on the -cloud channel. Which was surprising.

Because for example "beta-cluster-infrastructure" does show up there. This is infra but not beta cluster.

I added Toolforge soleley because this is hosted on toolforge.org. I did not expect it to remove cloud-services automatically. So ... I don't know.

bd808 triaged this task as High priority.May 16 2022, 8:40 PM
bd808 subscribed.

Triaging as high because I know that @Dzahn and others who work on Puppet cleanup rely on this feature of openstack-browser to get an idea of which manifests are in use.

[17:11]  <  mutante> openstack-browser stopped showing puppet classes and clicking other links seems slow / working sometimes. should I make a ticket or ongoing work?
[17:12]  <  mutante> f.e. https://openstack-browser.toolforge.org/puppetclass/ seems empty
[17:12]  <  mutante> I see backlog about outage on horizon. so maybe it's that then ack
[17:13]  <  mutante> ok, i'll just check in later again
[17:50]  <    bd808> mutante: I think we need a bug report for the openstack-browser things. I don't have time to dig in deeper at the moment, but it looks to me like the puppet-enc backend is now requiring auth even for browsing and that is making all the anon queries done by the tool fail. This is possibly unintended fallout of work taavi has been doing to add better auth to that puppet-enc service.
[17:51]  <    bd808> the app is doing things that are functionally `curl https://puppet-enc.cloudinfra.wmcloud.org:8143/v1/roles` -- https://phabricator.wikimedia.org/source/tool-keystone-browser/browse/master/keystone_browser/puppetclasses.py
[17:57]  <  mutante> bd808: ACK! will do that in a bit. thanks
[17:59]  <    taavi> that sounds like the most likely explanation, I thought I already migrated openstack-browser to use keystone authentication with puppet-enc :/
[18:00]  <    taavi> patches welcome, the proxies.py might have useful code you can almost copy-paste. otherwise will try to find some time to fix that soon-ish, but no promises due to irl priorities
[18:05]  <    bd808> *nod* looks like the `proxy_client` magic from https://phabricator.wikimedia.org/source/tool-keystone-browser/browse/master/keystone_browser/proxies.py is what puppetclasses.py also needs.
taavi claimed this task.