Page MenuHomePhabricator

Allow communities to define quality gate threshold in Special:EditGrowthConfig
Closed, ResolvedPublic

Description

Russian Wikipedia Add a link edits are more important than the number of edits the community can check. A possible solution would be to change the number of edits allowed per day.

We should allow communities in an easy way to decrease or increase the threshold if they like to. At the moment, the number can be changed in the JSON files, but not on Special:EditGrowthConfig.

And it should also be done for Add an image as well (T289027).

Acceptance criteria

  • Maximum tasks per day can be set for link recommendation on Special:EditGrowthConfig
  • Maximum tasks per day can be set for image recommendation on Special:EditGrowthConfig

Event Timeline

@Trizek-WMF The threshold is already stored within community configuration, but it is not yet available in the Special:EditGrowthConfig form (it should be trivial to add it there).

If someone wishes to change it now, they can go to https://ru.wikipedia.org/w/index.php?title=MediaWiki:NewcomerTasks.json&action=edit (or equivalent page for other projects) and add "maxTasksPerDay": X, below "maximumLinksToShowPerTask": 3, in the link-recommendation section, where X is the number of tasks they wish to allow.

Happy to answer any questions about this if there are any.

Trizek-WMF renamed this task from Allow communities to select quality gate threshold to Allow communities to define quality gate threshold in Special:EditGrowthConfig.May 17 2022, 5:18 PM
Trizek-WMF updated the task description. (Show Details)

Thank you @Urbanecm_WMF for the details. I recycled this task to work on changing Special:EditGrowthConfig. In the meantime, I'll document "manual" editing.

kostajh added subscribers: KStoller-WMF, kostajh.

See T289027: Add Image: Add tasktype-specific input groups to Special:EditGrowthConfig for a related task about the image recommendation task type.

I'll move this to "Upcoming work" rather than current sprint, but @KStoller-WMF if you want us to work on this sooner rather than later, please move it to that board.

Urbanecm_WMF triaged this task as High priority.
Urbanecm_WMF added a subscriber: MMiller_WMF.

Moving to current sprint per discussion with @MMiller_WMF.

We want to prioritize this task because of multiple communities feeling overwhelmed with patrolling link edits. We want them to be able to easily control the volume.

Change 800755 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Allow admins to edit maximum number of daily link tasks

https://gerrit.wikimedia.org/r/800755

Change 800755 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Allow admins to edit maximum number of daily link tasks

https://gerrit.wikimedia.org/r/800755

Urbanecm_WMF added a subscriber: Dyolf77_WMF.

The maximum number of daily add a link edits now can be configured via Special:EditGrowthConfig. It will be live with the next train (Thursday June 02 for Wikipedias). It looks like in the image below:

image.png (564×744 px, 30 KB)


I'm moving this to QA for now, but note there are other values that can be configured for add a link. Here's a list of configuration options we can easily add to the form – the current/default value for each of the options is in square brackets.

  • desired task pool size (per topic) [500]
  • minimum number of links for a task to be valid [2]
  • minimum link confidence score returned by the suggestion algorithm for a suggestion to be valid [50 %]
  • minimum time that needs to pass since last edit on the article for it to be suggested [1 day]
  • minimum/maximum size of article for it to be suggested [no restrictions].

I'm not sure whether any of those numbers is also considered quality gate-related. @Trizek-WMF @Dyolf77_WMF @KStoller-WMF @MMiller_WMF – should we include any of the above-mentioned fields to the form?

Change 800886 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Allow admins to edit maximum number of daily image tasks

https://gerrit.wikimedia.org/r/800886

Change 800886 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SpecialEditGrowthConfig: Allow admins to edit maximum number of daily image tasks

https://gerrit.wikimedia.org/r/800886

should we include any of the above-mentioned fields to the form?

Yes but maybe let's refactor it first so tasktype-specific forms can be handled by the tasktype instead of one huge method dealing with everything.

Also IMO it would be nice to make the form more navigable (collapsible sections, maybe?) as it has gotten rather large.

should we include any of the above-mentioned fields to the form?

Yes but maybe let's refactor it first so tasktype-specific forms can be handled by the tasktype instead of one huge method dealing with everything.

Huge +1 to the refactoring. We might even employ a class that serializes/deserializes configuration into/from form fields. I feel like the other config options are less important (and can wait a refactoring), but of course, I can be wrong.

Also IMO it would be nice to make the form more navigable (collapsible sections, maybe?) as it has gotten rather large.

I feel it's still within reasonable size, but I wouldn't mind making it easier to navigate at all.

I'm moving this to QA for now, but note there are other values that can be configured for add a link. Here's a list of configuration options we can easily add to the form – the current/default value for each of the options is in square brackets.

  • desired task pool size (per topic) [500]
  • minimum number of links for a task to be valid [2]
  • minimum link confidence score returned by the suggestion algorithm for a suggestion to be valid [50 %]
  • minimum time that needs to pass since last edit on the article for it to be suggested [1 day]
  • minimum/maximum size of article for it to be suggested [no restrictions].

I'm not sure whether any of those numbers is also considered quality gate-related. @Trizek-WMF @Dyolf77_WMF @KStoller-WMF @MMiller_WMF – should we include any of the above-mentioned fields to the form?

@Urbanecm_WMF -- thanks for checking. For those four things, are they configurations that would immediately apply to all articles in the feed? Or would they apply to new articles as they get scored and placed in the feed? I ask because I think communities would be frustrated if they changed something and it takes a while to show up in the feed. I know that that's already the case for the "sections that should be excluded" one.

@MMiller_WMF AFAICS, all of those options will only take effect during scoring, not when a newcomer clicks on the article (or when the Growth team tells MediaWiki to revalidate all suggestions in the task pool). @Tgr will likely be able to confirm that (or correct me if I'm wrong).

I've removed The maximum number can be as low as "zero" to temporarily disable the task (while still allowing users to see it in the UI) from the acceptance criterias, because we have a dedicated solution for disabling a task (there's a "Disabled" checkbox for that purpose). I don't think it makes sense to allow zero in this field.

Etonkovidova subscribed.

Tested in tetswiki wmf.18

  • Special:EditGrowthConfig displays the form.
Screen Shot 2022-07-01 at 4.21.55 PM.png (1×1 px, 178 KB)
Screen Shot 2022-07-01 at 4.22.01 PM.png (894×1 px, 137 KB)
  • the fields "The maximum number of "Add a link" suggested tasks a newcomer can complete daily." and "The maximum number of "Add an image" suggested tasks a newcomer can complete daily." work as expected.