Page MenuHomePhabricator

Display non-functional kebab menu on registration list
Open, Needs TriagePublic

Description

In scope (for V0):

  • Display kebab/"three dots" menu next to registrations in list for organizer view
    • It will be non-functional for V0

Screen Shot 2022-05-13 at 10.59.38 AM.png (1Γ—2 px, 213 KB)

Out of scope:

  • Implementing actions for the menu (edit, view close, delete) - captured in T308613 for V1 (MVP)

Decisions/updates:

  • The kebab/"three dots" menu is rotated 90 degrees from the the icon in the comp per T308607#7957847

Event Timeline

Implementing actions for the menu (edit, view close, delete) - captured in T308613 for V1 (MVP)

@ldelench_wmf @ifried Is this accurate? I remember we decided to have a separate task for the actions (T308613) and that it would be worked on after implementing the base pagination logic (T308607), but that it would still be in scope for V0, and possibly the current sprint.

(Also, FTR, I've already implemented the non-functional three dots for T308607, although there seem to be some issues with the icon, see T308607#7941136. So perhaps this task is not necessary)

Oh thanks @Daimona, perhaps I misunderstood in our meeting the other day; from the notes:

  • Actions for 3 dots (edit, view close, delete)
    • Not implementing for V0?
    • Display 3 dots but it’s not functional

I interpreted that as "we will display 3 dots icon in V0 but it won't actually do anything."

If I have indeed misinterpreted and we DO want to move ahead with making it functional as part of V0, we can decline this task and instead prioritize T308613.

Oh thanks @Daimona, perhaps I misunderstood in our meeting the other day; from the notes:

  • Actions for 3 dots (edit, view close, delete)
    • Not implementing for V0?
    • Display 3 dots but it’s not functional

Thank you! Unfortunately I don't remember that conversation very well. I'm sure we decided to break this down and have the menu non-functional at first, but I don't remember postponing it to V1.

@Daimona, I don't remember this conversation either, but I think it is probably fine to save the kebab menu to V1 (with one open question). In the case of 'Edit,' organizers can edit registration information on the event/registration details page, so that user flow is covered. For 'view event page,' I don't think that's critical for V0. For close registration, we don't need to include an open/close status for V0 (all registration is automatically open), so that's fine for now. The only concern I have is for 'delete registration.' In our V0 planning, we included 'Organizer can remove registration form' as one of the requirements. If they cannot do it via the kebab menu, where in the UI would this be possible?

Also pinging @gonyeahialam to see if he has any thoughts.

For close registration, we don't need to include an open/close status for V0 (all registration is automatically open), so that's fine for now.

We already have this in V0. However, now that I think about it, this is something that you can change from the "Edit event registration" special page, so it would be included in the "edit" action.

In general, adding the actions to the menu should be easy, so I'd be happy to do that for V0.

Hi there, I remember we decided to create a separate task to add the actions to the menu, and I also don't think they would be difficult to implement, and I think they are important features for V0.

Thanks for the responses, @Daimona & @cmelo! I agree that it would be nice to include the kebab menu if we can in V0 (especially since the work would be easy). I have created a separate ticket for the actions (T309048). But we may want to focus on building out the actions first, which are higher priority. I think it was mentioned that the special page for deleting registration hasn't been created yet (T308582). Perhaps we should work on it first? What do you two think? I'm open to whatever makes the most sense from an engineering perspective.

HI @ifried thanks, yes I agree we should work on the "delete registration special page".
What do you think @Daimona?

I have created a separate ticket for the actions (T309048).

Is it a duplicate of T308613?

But we may want to focus on building out the actions first, which are higher priority. I think it was mentioned that the special page for deleting registration hasn't been created yet (T308582). Perhaps we should work on it first? What do you two think? I'm open to whatever makes the most sense from an engineering perspective.

I think it definitely makes sense! However, as I already noted, there doesn't seem to be any wireframe/prototype for that page. I assume it should be just a confirmation form for now, so I may as well just create a basic page for now. @ifried If this works for you, should T308582 be moved into the current sprint board then? I'm hungry for more tickets.

@Daimona, I don't remember this conversation either, but I think it is probably fine to save the kebab menu to V1 (with one open question). In the case of 'Edit,' organizers can edit registration information on the event/registration details page, so that user flow is covered. For 'view event page,' I don't think that's critical for V0. For close registration, we don't need to include an open/close status for V0 (all registration is automatically open), so that's fine for now. The only concern I have is for 'delete registration.' In our V0 planning, we included 'Organizer can remove registration form' as one of the requirements. If they cannot do it via the kebab menu, where in the UI would this be possible?

Also pinging @gonyeahialam to see if he has any thoughts.

@ifried Organizers can also delete on the event details page

Screenshot 2022-05-25 at 10.50.01.png (1Γ—2 px, 286 KB)

I have created a separate ticket for the actions (T309048).

Is it a duplicate of T308613?

But we may want to focus on building out the actions first, which are higher priority. I think it was mentioned that the special page for deleting registration hasn't been created yet (T308582). Perhaps we should work on it first? What do you two think? I'm open to whatever makes the most sense from an engineering perspective.

I think it definitely makes sense! However, as I already noted, there doesn't seem to be any wireframe/prototype for that page. I assume it should be just a confirmation form for now, so I may as well just create a basic page for now. @ifried If this works for you, should T308582 be moved into the current sprint board then? I'm hungry for more tickets.

@Daimona The flow for delete isn't in the design but it was supposed to be a pop-up confirmation.
Did we finalize what happens to the data of registered participants when an Organizer deletes an event? @ifried Can you help with the link to the ticket where this was discussed?

Change 776981 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Create the MyEvents special page

https://gerrit.wikimedia.org/r/776981

@gonyeahialam Apologies, I don't know what ticket you are referring to.

Change 776981 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Create the MyEvents special page

https://gerrit.wikimedia.org/r/776981

@ifried noting here that the kebab/"three dots" menu is rotated 90 degrees from the the icon in the comp and this change was as an intentional change as noted in T308607#7957847