Remove inactive code for Element Timing experiment
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	May 17 2022, 10:50 PM

Description

Following T216598 and the declined T230808, we still have experimental code left behind in MediaWiki core and the parser's thumbnail logic. (I was reminded of this via T307747).

The scope of this task is to remove the feature flag and the associated (unsupported and untested) experiment code.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
eventlogging: Remove obsoleted navtiming schemas	operations/puppet	production	+0 -10
Remove elementtiming,firstinputtiming,layoutshift,resourcetiming,rumspeedindex	schemas/event/secondary	master	+0 -2 K
Remove former EventLogging streams for navtiming	operations/mediawiki-config	master	+0 -48
Bump wikimedia/parsoid to 0.16.0-a11	mediawiki/vendor	master	+100 -96
Remove priority hints and element timing from test normalization	mediawiki/services/parsoid	master	+0 -8
Remove PriorityHints role and ElementTiming	mediawiki/vagrant	master	+0 -20
parser: Remove Element Timing experiment for thumbnails	mediawiki/core	master	+2 -43
Remove wgElementTiming setting	operations/mediawiki-config	master	+0 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Peter	T290019 Review navigation timing extension
Open	None	T319329 Expand navigation timing metrics to include user experience metrics and modernise navigation timing
Resolved	Krinkle	T286703 Navigation Timing cleanup
Resolved	Mainframe98	T308621 Remove inactive code for Element Timing experiment

Event Timeline

Krinkle created this task.May 17 2022, 10:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 17 2022, 10:50 PM

Krinkle mentioned this in T307747: Native image lazyloading should not apply to images above the fold.May 17 2022, 10:53 PM

Change 793008 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] Remove experimental Element Timing experiment

https://gerrit.wikimedia.org/r/793008

gerritbot added a project: Patch-For-Review.May 18 2022, 9:59 AM

Change 793029 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[operations/mediawiki-config@master] Remove ElementTiming

https://gerrit.wikimedia.org/r/793029

I've added the removal from InitialiseSettings.php to this task as well, as finding it otherwise would be a pain, like the original removal was.

Change 793108 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/services/parsoid@master] Remove elementtiming from test normalization

https://gerrit.wikimedia.org/r/793108

Krinkle mentioned this in T308707: Remove inactive code from Priority Hints experiment in MW core.May 18 2022, 8:37 PM

Change 793008 merged by jenkins-bot:

[mediawiki/core@master] parser: Remove Element Timing experiment for thumbnails

https://gerrit.wikimedia.org/r/793008

Change 793029 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wgElementTiming setting

https://gerrit.wikimedia.org/r/793029

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 18 2022, 9:00 PM

Change 793419 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/vagrant@master] PriorityHints role and ElementTiming

https://gerrit.wikimedia.org/r/793419

Change 793419 merged by jenkins-bot:

[mediawiki/vagrant@master] Remove PriorityHints role and ElementTiming

https://gerrit.wikimedia.org/r/793419

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.May 24 2022, 7:06 PM

Change 793108 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove priority hints and element timing from test normalization

https://gerrit.wikimedia.org/r/793108

Mainframe98 closed this task as Resolved.Jun 1 2022, 7:06 PM

Mainframe98 removed a project: Patch-For-Review.

Change 803313 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a11

https://gerrit.wikimedia.org/r/803313

gerritbot added a project: Patch-For-Review.Jun 6 2022, 3:49 PM

Change 803313 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.16.0-a11

https://gerrit.wikimedia.org/r/803313

Krinkle renamed this task from Remove inactive code from Element Timing experiment in MW core to Remove inactive code for Element Timing experiment.Nov 28 2022, 9:43 AM

Krinkle added a parent task: T286703: Navigation Timing cleanup.

Change 726852 had a related patch set uploaded (by Krinkle; author: Peter Hedenskog):

[operations/puppet@production] eventlogging: Remove obsoleted navtiming schemas

https://gerrit.wikimedia.org/r/726852

Change 879926 had a related patch set uploaded (by Krinkle; author: Krinkle):

[operations/mediawiki-config@master] Remove former EventLogging streams for navtiming

https://gerrit.wikimedia.org/r/879926

Change 879926 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove former EventLogging streams for navtiming

https://gerrit.wikimedia.org/r/879926

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:17:44Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:879926|Remove former EventLogging streams for navtiming (T281103 T286703 T308621 T323623)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:19:32Z] <ladsgroup@deploy1002> ladsgroup and krinkle: Backport for [[gerrit:879926|Remove former EventLogging streams for navtiming (T281103 T286703 T308621 T323623)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:27:27Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:879926|Remove former EventLogging streams for navtiming (T281103 T286703 T308621 T323623)]] (duration: 09m 42s)