Page MenuHomePhabricator

Remove legacy functions
Open, LowPublic

Description

From puppet 7 legacy functions are no longer supported as such we should either drop them if they are no longer needed to update them to use either a puppet function or the newer ruby API https://puppet.com/docs/puppet/latest/functions_refactor_legacy.html.

From a quick search the following are legacy functions

modules/admin/lib/puppet/parser/functions/add_all_users.rb
modules/admin/lib/puppet/parser/functions/unique_users.rb
modules/graphite/lib/puppet/parser/functions/configparser_format.rb
modules/labstore/lib/puppet/parser/functions/mount_nfs_volume.rb
modules/librenms/lib/puppet/parser/functions/phpdump.rb
modules/mediawiki/lib/puppet/parser/functions/compile_redirects.rb
modules/network/lib/puppet/parser/functions/slice_network_constants.rb
modules/profile/lib/puppet/parser/functions/nutcracker_pools.rb
modules/redis/lib/puppet/parser/functions/redis_get_instances.rb
modules/redis/lib/puppet/parser/functions/redis_shard_hosts.rb
modules/role/lib/puppet/parser/functions/kafka_cluster_name.rb
modules/role/lib/puppet/parser/functions/kafka_config.rb
modules/service/lib/puppet/parser/functions/merge_config.rb
modules/wmflib/lib/puppet/parser/functions/cron_splay.rb
modules/wmflib/lib/puppet/parser/functions/ensure_mounted.rb
modules/wmflib/lib/puppet/parser/functions/get_clusters.rb
modules/wmflib/lib/puppet/parser/functions/htpasswd.rb
modules/wmflib/lib/puppet/parser/functions/init_template.rb
modules/wmflib/lib/puppet/parser/functions/ipresolve.rb
modules/wmflib/lib/puppet/parser/functions/puppet_ssldir.rb
modules/wmflib/lib/puppet/parser/functions/requires_realm.rb
modules/wmflib/lib/puppet/parser/functions/secret.rb
modules/wmflib/lib/puppet/parser/functions/ssl_ciphersuite.rb
modules/wmflib/lib/puppet/parser/functions/systemd_template.rb

Related Objects

Event Timeline

Change 792989 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] admin: convert add_all_users to puppet logic

https://gerrit.wikimedia.org/r/792989

Change 793031 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] admin: convert unique_users function to puppet function

https://gerrit.wikimedia.org/r/793031

Change 792989 merged by Jbond:

[operations/puppet@production] admin: convert add_all_users to puppet logic

https://gerrit.wikimedia.org/r/792989

Change 793031 merged by Jbond:

[operations/puppet@production] admin: convert unique_users function to puppet function

https://gerrit.wikimedia.org/r/793031

Change 793064 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] wmflib::configparser_format: Replace legacy function with puppet function

https://gerrit.wikimedia.org/r/793064

Change 793075 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] C:librenms: move phpdump to the template

https://gerrit.wikimedia.org/r/793075

Change 793075 merged by Jbond:

[operations/puppet@production] C:librenms: move phpdump to the template

https://gerrit.wikimedia.org/r/793075

Change 793081 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] wmflib: port ipresolve to the new api

https://gerrit.wikimedia.org/r/793081

Change 793110 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] nitcracker: remove :nutcracker_pools function as its unused

https://gerrit.wikimedia.org/r/793110

Change 793111 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] P:profile::redis::multidc: drop legacy function redis_get_instances

https://gerrit.wikimedia.org/r/793111

Change 793113 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] C:redis::multidc::ipsec: migrate legacy redis_shard_hosts to puppet code

https://gerrit.wikimedia.org/r/793113

Change 793430 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] replace wmflib's ensuremounted with stdlib::ensure

https://gerrit.wikimedia.org/r/793430

Change 793430 merged by Jbond:

[operations/puppet@production] replace wmflib's ensuremounted with stdlib::ensure

https://gerrit.wikimedia.org/r/793430

jbond updated the task description. (Show Details)

Change 793110 merged by Jbond:

[operations/puppet@production] nitcracker: remove :nutcracker_pools function as its unused

https://gerrit.wikimedia.org/r/793110

Change 793821 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] P:kafka: drop legacy kefka_config and kafka_config_name functions

https://gerrit.wikimedia.org/r/793821

Change 793111 merged by Jbond:

[operations/puppet@production] P:profile::redis::multidc: drop legacy function redis_get_instances

https://gerrit.wikimedia.org/r/793111

Change 793113 merged by Jbond:

[operations/puppet@production] C:redis::multidc::ipsec: migrate legacy redis_shard_hosts to puppet code

https://gerrit.wikimedia.org/r/793113

Change 800219 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] service::node::config: drop merge_config

https://gerrit.wikimedia.org/r/800219

Change 800242 had a related patch set uploaded (by Jbond; author: John Bond):

[operations/puppet@production] wmflib::clusters::fetch: possible replacement for cluster_config

https://gerrit.wikimedia.org/r/800242

Change 907938 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] wmflib: updat ipresolv to work with puppet7

https://gerrit.wikimedia.org/r/907938

Change 907938 merged by Jbond:

[operations/puppet@production] wmflib: updat ipresolv to work with puppet7

https://gerrit.wikimedia.org/r/907938

Change 793064 abandoned by Jbond:

[operations/puppet@production] wmflib::configparser_format: Replace legacy function with puppet function

Reason:

replaced allready

https://gerrit.wikimedia.org/r/793064

jhathaway triaged this task as Low priority.

A quick note, relevant to T240941 as well. puppet_ssldir AFAICS has become an even bigger liability with the move to puppetserver: profile::puppetserver changes ssldir paths depending on a combination of ssldir_on_srv and separate_ssldir, which won't be reflected on the output of puppet_ssldir invocations