Page MenuHomePhabricator
Create Task
Maniphest T308653

Add link to project page next to Minerva skin listing
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

In T307113, the Readers Web team is adding a 'Discussion' link next to Vector 2022 in the list of skins, so that users can more easily give feedback on this skin. We could do the same for MinervaNeue, since we're currently making changes to that skin.

Acceptance criteria

Details

SubjectRepoBranchLines +/-
Add discussion link next to MinervaNeue skin optionmediawiki/skins/MinervaNeuemaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Samwalton9-WMF created this task.May 18 2022, 10:11 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMay 18 2022, 10:11 AM
Samwalton9-WMF triaged this task as Low priority.May 18 2022, 10:11 AM

It looks like the patches for T307113 enable this functionality by simply adding a message with the correct skin key.

Samwalton9-WMF updated the task description. (Show Details)May 18 2022, 10:13 AM
Samwalton9-WMF updated the task description. (Show Details)
Jdlrobson subscribed.May 18 2022, 2:30 PM

Yep, I can confirm that's all that would be needed :)

Samwalton9-WMF moved this task from Inbox to Kanban on the Moderator-Tools-Team board.May 23 2022, 1:07 PM
Samwalton9-WMF edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Samwalton9-WMF set the point value for this task to 2.May 25 2022, 4:58 PM
Scardenasmolinar claimed this task.Jun 1 2022, 12:51 AM
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Jun 1 2022, 11:33 PM

Change 802216 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/skins/MinervaNeue@master] Add discussion link next to MinervaNeue skin option

https://gerrit.wikimedia.org/r/802216

gerritbot added a project: Patch-For-Review.Jun 1 2022, 11:33 PM
Scardenasmolinar moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Jun 1 2022, 11:37 PM

This is ready for review!

jsn.sherman moved this task from Code review to Done on the Moderator-Tools-Team (Kanban) board.Jun 2 2022, 3:38 PM
jsn.sherman subscribed.

+2ed and waiting for deployment

gerritbot added a comment.Jun 2 2022, 3:56 PM

Change 802216 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add discussion link next to MinervaNeue skin option

https://gerrit.wikimedia.org/r/802216

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2022, 4:31 PM
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 2 2022, 5:00 PM
Samwalton9-WMF added a comment.Jun 16 2022, 10:00 AM

Tested that the link is present and goes to the intended destination :)

Samwalton9-WMF closed this task as Resolved.Jun 16 2022, 2:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL