Pretty sure this is provided by Extension:CodeEditor, so have tagged CodeEditor instead :)

I couldn't immediately see a config variable for this, but I feel like its something to do with the $wgScribuntoEngineConf here?

<sarcasm>
Side note, seeing as we have

• CodeMirror
• CodeEditor
• WikiEditor

we definitely need to create MirrorMirror, and EditorMirror
</sarcasm>

In T308679#7938784, @TheresNoTime wrote:

Pretty sure this is provided by Extension:CodeEditor, so have tagged CodeEditor instead :)

I couldn't immediately see a config variable for this, but I feel like its something to do with the $wgScribuntoEngineConf here?

I don't think so. I found this issue on Github which links maxerr in ace/lib/ace/mode/javascript_worker.js. For us this is found in https://en.wikipedia.org/w/extensions/CodeEditor/modules/ace/worker-javascript.js. There's a window.ace object but I can't find changeOptions in it.

<sarcasm>
Side note, seeing as we have

• CodeMirror
• CodeEditor
• WikiEditor

we definitely need to create MirrorMirror, and EditorMirror
</sarcasm>

Here's an EditorEditor. :-)

In T308679#7938784, @TheresNoTime wrote:

Pretty sure this is provided by Extension:CodeEditor, so have tagged CodeEditor instead :)

I couldn't immediately see a config variable for this, but I feel like its something to do with the $wgScribuntoEngineConf here?

It's definitely maxerr. Here's how to reliably reproduce this: https://commons.wikimedia.beta.wmflabs.org/wiki/User:AJ/toomanyerrors.js

It's counting strict errors, but it's not running in strict mode. Aborting after 100 errors have been shown is sensible, but when not running in strict mode those "errors" aren't shown at all.

I propose we just multiply maxerr with a factor 1000 or so. Doesn't solve the underlying issue, but good enough for us.

In T308679#7957359, @AlexisJazz wrote:

In T308679#7938784, @TheresNoTime wrote:

Pretty sure this is provided by Extension:CodeEditor, so have tagged CodeEditor instead :)

I couldn't immediately see a config variable for this, but I feel like its something to do with the $wgScribuntoEngineConf here?

I don't think so. I found this issue on Github which links maxerr in ace/lib/ace/mode/javascript_worker.js. For us this is found in https://en.wikipedia.org/w/extensions/CodeEditor/modules/ace/worker-javascript.js. There's a window.ace object but I can't find changeOptions in it.

Oooh, you're quite right..

In T308679#7957695, @AlexisJazz wrote:

In T308679#7938784, @TheresNoTime wrote:

Pretty sure this is provided by Extension:CodeEditor, so have tagged CodeEditor instead :)

I couldn't immediately see a config variable for this, but I feel like its something to do with the $wgScribuntoEngineConf here?

It's definitely maxerr. Here's how to reliably reproduce this: https://commons.wikimedia.beta.wmflabs.org/wiki/User:AJ/toomanyerrors.js

It's counting strict errors, but it's not running in strict mode. Aborting after 100 errors have been shown is sensible, but when not running in strict mode those "errors" aren't shown at all.

I propose we just multiply maxerr with a factor 1000 or so. Doesn't solve the underlying issue, but good enough for us.

I'm going to set maxerr: 1000 (tested User:AJ/toomanyerrors.js and User:NguoiDungKhongDinhDanh/diff-context.js locally, it "resolves" the error) — we should see how that goes & try to resolve the root cause

Change 799384 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/CodeEditor@master] Ace editor config: Increase maxerr

https://gerrit.wikimedia.org/r/799384

Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c2b4c82f0c/w/

In T308679#7957851, @PatchDemoBot wrote:

Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c2b4c82f0c/w/

https://patchdemo.wmflabs.org/wikis/c2b4c82f0c/w/index.php?title=User:Patch_Demo/test.js&action=edit

In T308679#7957890, @TheresNoTime wrote:

In T308679#7957851, @PatchDemoBot wrote:

Test wiki created on Patch demo by TheresNoTime using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/c2b4c82f0c/w/

https://patchdemo.wmflabs.org/wikis/c2b4c82f0c/w/index.php?title=User:Patch_Demo/test.js&action=edit

Thanks, I was able to change the contents after messing around a bit.

1000 isn't enough for Bawl for which JSHint normally reports no errors: https://en.wikipedia.org/wiki/User:Alexis_Jazz/Bawl-test.js. On your demo page "too many errors" is triggered at line 1760 (out of 6645). Maybe 10000 would cover most scripts?

For Bawl, there are two types of error that cause the ceiling to be reached:

• Ironic Missing "use strict" statement. errors for every single function.
• $ is not declared errors. Just repeating $('body'); 101 times also triggers "too many errors". In JSHint there's this "assume jQuery" option, can that be enabled somehow here as well? (putting /*globals $:false */ in the script also works, but isn't that pretty) Maybe 1000 would be enough if $ was ignored, Bawl has "only" 300 functions.

It seems Bawl is already strict-compliant, just not declared as such, so for Bawl I'll switch to strict mode soon.

Test wiki on Patch demo by TheresNoTime using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c2b4c82f0c/w/