Page MenuHomePhabricator

Ctrl+click doesn't always open a new tab when selecting a language
Closed, ResolvedPublicBUG REPORT


That's a really annoying one.

List of steps to reproduce:

  • Open any wiki page with interwikis.
  • Click the number of languages.
    image.png (36×186 px, 1 KB)
  • Move the cursor to the left (or upper, or lower, or right) border of the highlighted area of any language in the list.
    image.png (212×252 px, 8 KB)
  • Ctrl+click to open the page in another language in a new tab.

What happens?:
A new tab doesn't open. The page loads in the same tab.

What should have happened instead?:
A new tab should open.

The reason for this is that the highlighted area is not equal to the link area. A LI item is highlighted instead of A.

image.png (214×256 px, 10 KB)

A is inside the blue area here, while the green area (LI's padding) is highlighted too. Right click on the green area doesn't work for the link as well, obviously.

To enlarge the link area to the borders of LI, and to make it responsible for highlighting instead of LI to remove the discrepancy between what area is relevant and what area is highlighted.

Event Timeline

Change 805081 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.ime and jquery.uls from upstream

Change 805081 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Update jquery.ime and jquery.uls from upstream

Ctrl+click on the language within the language selector now opens in the different tab within the same browser and launches in the selected language

Testing status: QA PASS