Remove inactive code from Priority Hints experiment in MW core
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	May 18 2022, 8:37 PM

Description

We still have unused code left behind in MediaWiki core from the 2019 experiment for Priority Hints (T216499), which resides in the parser's thumbnail logic. (I was reminded of this via T307747).

This was introduced around the same time as the Element Timing experiment which we also since removed (T308621).

Note that "Priority Hints" is not just experimental in MW, but is also an experimental Web standard that was only exposed as a Google Chrome Origin Trial, and the standard has since evolved further in a way that is no longer compatible (e.g. differnet attributes, etc.)

Details

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.16.0-a11	mediawiki/vendor	master	+100 -96
Remove priority hints and element timing from test normalization	mediawiki/services/parsoid	master	+0 -8
Remove wgPriorityHints and wgPriorityHintsRatio	operations/mediawiki-config	master	+0 -8
parser: Remove Priority Hints experiment for thumbnails	mediawiki/core	master	+2 -81
Remove PriorityHints role and ElementTiming	mediawiki/vagrant	master	+0 -20

Customize query in gerrit

Related Objects

Mentioned Here: T216499: Priority Hints origin trial
T307747: Native image lazyloading should not apply to images above the fold
T308621: Remove inactive code for Element Timing experiment

Event Timeline

Krinkle created this task.May 18 2022, 8:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 18 2022, 8:37 PM

I looked into this as part of T308621, so I might as well take this on too.

Change 793396 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/core@master] parser: Remove Priority Hints experiment for thumbnails

https://gerrit.wikimedia.org/r/793396

Change 793108 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/services/parsoid@master] Remove priority hints and element timing from test normalization

https://gerrit.wikimedia.org/r/793108

Change 793402 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[operations/mediawiki-config@master] Remove wgPriorityHints and wgPriorityHintsRatio

https://gerrit.wikimedia.org/r/793402

Change 793419 had a related patch set uploaded (by Mainframe98; author: Mainframe98):

[mediawiki/vagrant@master] PriorityHints role and ElementTiming

https://gerrit.wikimedia.org/r/793419

Change 793419 merged by jenkins-bot:

[mediawiki/vagrant@master] Remove PriorityHints role and ElementTiming

https://gerrit.wikimedia.org/r/793419

Change 793396 merged by jenkins-bot:

[mediawiki/core@master] parser: Remove Priority Hints experiment for thumbnails

https://gerrit.wikimedia.org/r/793396

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 21 2022, 6:00 PM

Change 793402 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wgPriorityHints and wgPriorityHintsRatio

https://gerrit.wikimedia.org/r/793402

Mentioned in SAL (#wikimedia-operations) [2022-05-24T07:33:40Z] <ladsgroup@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:793402|Remove wgPriorityHints and wgPriorityHintsRatio (T308707)]] (duration: 00m 50s)