Page MenuHomePhabricator

ResourceLoader namespace
Closed, ResolvedPublic

Description

The ResourceLoader classes will be moved to the MediaWiki\ResourceLoader namespace.

All class names will have the "ResourceLoader" prefix removed from them except ResourceLoader and ResourceLoaderContext.

I am introducing a convention where the namespace is imported with the alias RL, so that you have e.g. RL\Module as the new name for ResourceLoaderModule instead of just Module.

There is a bug in Phan which causes a spurious PhanParamSignatureRealMismatchParamType error on classes using the old \ResourceLoaderContext type on parameter type declarations for classes extending ResourceLoaderModule, only if the target PHP version is less than 7.4 (T308443). To work around this, either simultaneously update the affected extension, or to add @phan-suppress PhanParamSignatureRealMismatchParamType to the doc comment.

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+40 -21
mediawiki/extensions/TEImaster+4 -5
mediawiki/skins/Timelessmaster+5 -5
mediawiki/extensions/WikimediaMessagesmaster+1 -1
mediawiki/extensions/Gadgetsmaster+15 -17
mediawiki/skins/MinervaNeuemaster+4 -2
mediawiki/extensions/AdvancedSearchmaster+7 -8
mediawiki/extensions/UseResourcemaster+3 -3
mediawiki/extensions/SyntaxHighlight_GeSHimaster+8 -10
mediawiki/extensions/Gravatarmaster+12 -5
mediawiki/extensions/QuickSurveysmaster+7 -7
mediawiki/extensions/TemplateSandboxmaster+2 -2
mediawiki/extensions/Kartographermaster+10 -10
mediawiki/extensions/CentralNoticemaster+14 -8
mediawiki/extensions/Echomaster+8 -6
mediawiki/skins/Vectormaster+15 -17
mediawiki/extensions/WikibaseLexememaster+23 -23
mediawiki/extensions/Wikibasemaster+76 -74
mediawiki/extensions/CheckUsermaster+4 -4
mediawiki/extensions/PageTriagemaster+10 -10
mediawiki/extensions/WikiEditormaster+6 -6
mediawiki/extensions/CentralAuthmaster+11 -10
mediawiki/extensions/GlobalCssJsmaster+13 -13
mediawiki/extensions/WikimediaMaintenancemaster+16 -14
mediawiki/extensions/NavigationTimingmaster+3 -3
mediawiki/extensions/EventLoggingmaster+3 -3
mediawiki/extensions/WikimediaEventsmaster+10 -11
mediawiki/extensions/CodeMirrormaster+6 -7
mediawiki/extensions/VisualEditormaster+6 -6
mediawiki/extensions/Mathmaster+9 -11
mediawiki/extensions/Scoremaster+8 -9
mediawiki/extensions/Graphmaster+5 -6
mediawiki/extensions/DiscussionToolsmaster+9 -11
mediawiki/extensions/Citoidmaster+11 -12
mediawiki/extensions/Citemaster+15 -14
mediawiki/extensions/MobileFrontendmaster+10 -8
mediawiki/extensions/GrowthExperimentsmaster+43 -44
mediawiki/coremaster+1 K -1 K
mediawiki/extensions/GuidedTourmaster+6 -7
mediawiki/extensions/CognitiveProcessDesignermaster+6 -6
mediawiki/extensions/UniversalLanguageSelectormaster+17 -17
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 793577 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/DiscussionTools@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793577

Change 793578 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Echo@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793578

Change 793579 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/EventLogging@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793579

Change 793580 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/GlobalCssJs@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793580

Change 793581 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Graph@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793581

Change 793582 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Gravatar@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793582

Change 793583 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/GrowthExperiments@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793583

Change 793584 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/GuidedTour@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793584

Change 793585 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Kartographer@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793585

Change 793606 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Math@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793606

Change 793607 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/MobileFrontend@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793607

Change 793608 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/NavigationTiming@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793608

Change 793609 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/PageTriage@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793609

Change 793610 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/QuickSurveys@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793610

Change 793611 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Score@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793611

Change 793612 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/TEI@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793612

Change 793613 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/TemplateSandbox@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793613

Change 793614 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/UniversalLanguageSelector@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793614

Change 793615 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/UseResource@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793615

Change 793616 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/VisualEditor@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793616

Change 793617 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/Wikibase@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793617

Change 793618 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/WikibaseLexeme@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793618

Change 793619 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/WikiEditor@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793619

Change 793620 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/WikimediaEvents@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793620

Change 793621 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/WikimediaMaintenance@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793621

Change 793622 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793622

For all Gerrit extensions with a .phan directory, I grepped for ResourceLoader and migrated all usages to the new namespace. As in the core patch, I used RL as an alias for the namespace, except that I imported the ResourceLoader class separately instead of using the redundant RL\ResourceLoader. In some cases, in tests or where there was no danger of ambiguity, I used plain imports instead of an alias.

Editing was done in vim, without much automation. Committing and uploading was automated, except for a manual rebase in SyntaxHighlight_GeSHi.

Here is the concatenated diff of all 35 affected extensions: P28163

Here is the list of extensions: AdvancedSearch CentralAuth CentralNotice CheckUser Cite Citoid CodeMirror CognitiveProcessDesigner DiscussionTools Echo EventLogging Gadgets GlobalCssJs Graph Gravatar GrowthExperiments GuidedTour Kartographer Math MobileFrontend NavigationTiming PageTriage QuickSurveys Score SyntaxHighlight_GeSHi TEI TemplateSandbox UniversalLanguageSelector UseResource VisualEditor Wikibase WikibaseLexeme WikiEditor WikimediaEvents WikimediaMaintenance

Change 793614 abandoned by Tim Starling:

[mediawiki/extensions/UniversalLanguageSelector@master] Use new ResourceLoader namespace

Reason:

https://gerrit.wikimedia.org/r/793614

Change 793576 merged by Robert Vogel:

[mediawiki/extensions/CognitiveProcessDesigner@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793576

Change 793391 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader namespace (attempt 2)

https://gerrit.wikimedia.org/r/793391

Change 793584 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793584

Change 793583 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793583

Change 793607 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793607

Change 793573 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793573

Change 793574 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793574

Change 793577 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793577

Change 793581 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793581

Change 793611 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793611

Change 793606 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793606

Change 793616 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793616

Change 793575 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793575

Change 793620 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793620

Change 793579 merged by jenkins-bot:

[mediawiki/extensions/EventLogging@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793579

Change 793608 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793608

Change 793580 merged by jenkins-bot:

[mediawiki/extensions/GlobalCssJs@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793580

Change 793570 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793570

Change 793621 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793621

Change 793619 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793619

Change 793609 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793609

Change 799020 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/skins/Vector@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/799020

Change 793572 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793572

Change 793391 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader namespace (attempt 2)

https://gerrit.wikimedia.org/r/793391

Breaking CI for Wikibase and idk how many other extensions again, since not all of the fixing changes had been +2ed yet…

Change 793617 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793617

Change 793618 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793618

Change 799020 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/799020

Change 793578 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793578

Change 793571 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793571

Breaking CI for Wikibase and idk how many other extensions again, since not all of the fixing changes had been +2ed yet…

Sorry about that Lucas, we should have made sure to approve them all prior to the core patch being merged. I can't self-merge them unless they have a +1.

Change 793585 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793585

Change 800293 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use new ResourceLoader namespaces

https://gerrit.wikimedia.org/r/800293

Change 793613 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793613

Change 793610 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793610

Change 793582 merged by jenkins-bot:

[mediawiki/extensions/Gravatar@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793582

Change 793622 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793622

Change 793615 merged by jenkins-bot:

[mediawiki/extensions/UseResource@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793615

Change 793569 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793569

Change 800293 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use new ResourceLoader namespaces

https://gerrit.wikimedia.org/r/800293

Change 800698 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Gadgets@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/800698

Change 800698 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/800698

Change 801339 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaMessages@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/801339

Krinkle lowered the priority of this task from Unbreak Now! to High.May 30 2022, 10:17 AM

Change 801339 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/801339

Change 808092 had a related patch set uploaded (by Bartosz Dziewoński; author: Perryprog):

[mediawiki/skins/Timeless@master] Use correct namespace for ResourceLoader\Context

https://gerrit.wikimedia.org/r/808092

Change 808092 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Use correct namespace for ResourceLoader\Context

https://gerrit.wikimedia.org/r/808092

Change 793612 merged by jenkins-bot:

[mediawiki/extensions/TEI@master] Use new ResourceLoader namespace

https://gerrit.wikimedia.org/r/793612

Change 822121 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Use more readable cache group for MessageBlobStore

https://gerrit.wikimedia.org/r/822121

Change 822121 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Use more readable cache group for MessageBlobStore

https://gerrit.wikimedia.org/r/822121