Page MenuHomePhabricator

PageHTMLHandler should return different eTag for different output modes
Closed, ResolvedPublic

Description

Currently, PageHTMLHandler will return the same eTag when returning the same (flavor of, see T308743) rendering of a page, regardless of whether the HTML is returned plain or wrappeed.

But etags must be different when the output is different. So when the HTML is wrapped, the etag must change.

Details

Event Timeline

daniel triaged this task as Unbreak Now! priority.May 24 2022, 7:58 AM
daniel lowered the priority of this task from Unbreak Now! to Needs Triage.
daniel triaged this task as High priority.
DAlangi_WMF renamed this task from PageHTMLHandler should return different eTag for different response formats to PageHTMLHandler should return different eTag for different output modes.May 24 2022, 9:14 PM

Change 798992 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] Return different eTags for different output modes

https://gerrit.wikimedia.org/r/798992

Change 798992 merged by jenkins-bot:

[mediawiki/core@master] Rest: Return different eTags for different output modes

https://gerrit.wikimedia.org/r/798992

DAlangi_WMF changed the task status from Open to In Progress.May 26 2022, 11:51 AM
daniel claimed this task.